-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge/IE fail to set Content-Type header on XHR whose body is a typed Blob #44
Comments
hmm, it do look badly formatted. Could you try to dump the actual blob that are being sent using this client side code? var blob = formdata._blob()
var fr = new FileReader
fr.onload = function() {
console.log(fr.result)
}
fr.readAsText(blob) for me it looks something like:
which is correct. Would also help if you dumped the request headers... specifically the content-type header you get in your server |
Using the code you provided I got the following ( see the screenshot as I am testing using BrowserStack and cannot copy/paste easily ), which looks ok. So then it's an issue on the backend side.Is that possible that the formdata-polyfill prefix is conflicting with the form entry parsing library of my current framework ? |
Got to be a problem on the server side... Things you can check:
PHP should be able to parse it |
I'll check that ;-) |
chromes FormData don't look much different fd = new FormData
fd.append('key', 'value')
new Response(fd).text().then(console.log)
result = `
------WebKitFormBoundary9F5Xu977y9H9FXm0
Content-Disposition: form-data; name="key"
value
------WebKitFormBoundary9F5Xu977y9H9FXm0--
` note: so you can instead send the blob... |
I'm not sure how you can miss something like a |
Weird. try sending the blob then and see what happens... the polyfill also got another trick in the sleeve, |
mather of fact, it looks to me like you are inspecting the response body, response header & the response content-type |
Ok on the client side I was missing the Content-Type : multipart/form-data which explains the emptyness of the request body when inspecting. Remaining issue is on the backend side. Thanks for your attention, I have been making some progress ;-) And your library has no issue then. |
Was snooping around on browserstack myself when you reveled your website. If you would perhaps do it like this: var blob = formdata._blob();
xhr.open( method, url );
xhr.setRequestHeader( "X-Requested-With", "XMLHttpRequest" );
xhr.setRequestHeader( "Content-Type", blob.type );
xhr.send( blob ); would it work for you then? |
In that case i might make a patch where i set the content-type header in the polyfill |
I am testing. |
The spec is: If you are sending a Blob/file with ajax and no content-type header is specified it should use the Files type as content-type. IE don't seems to follow that rule? |
Yes I can confirm your patch works fine. Stupid IE. |
Gah, hate IE. Going to make a patch to fix it. |
found something related: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6047383/ |
Top ! And really thanks for your time ;-) |
I am not that familiar with the use of Blobs so I did not look in that direction but yeah, your article seems to correspond to the situation. |
Fixed in |
👍 |
Tested but got an issue being:
The incriminated line being: XMLHttpRequest.prototype.send=function(b){b instanceof H&&(b=b.a(),this.setRequestHeader("Content-Type", b.type)) |
Forgot closure compiler mangels private properties/methods starting with |
Works perfect ! |
When posting gzipped data from posthog-js (gzip-js), all browsers except IE11 send content-type as 'text/plain'. IE11 has a bug (jimmywarting/FormData#44) where it fails to do that, causing us to dismiss these events. This only occurs when using bin/docker-server and not bin/start-backend. Related PR: PostHog/posthog-js#180
When posting gzipped data from posthog-js (gzip-js), all browsers except IE11 send content-type as 'text/plain'. IE11 has a bug (jimmywarting/FormData#44) where it fails to do that, causing us to dismiss these events. This only occurs when using bin/docker-server and not bin/start-backend. Related PR: PostHog/posthog-js#180
Hello Jimmy,
I am using your polyfill on my current project to be able to use the FormData object on IE 11, and it seems good until the request is actually processed by the server.
Working on a PHP back-end, when I var_dump the request Body I got something which looks like the following:
And so on. Obviously this body seems badly-formed.
I am using your polyfill by requiring it from my main JS entry file:
And to submit my form I am using the following code:
The content of formData is ok at this point ( I displayed the key value content to be sure ). So I am not sure of the source of the issue. Any Idea ?
It's blocking for me right now, as I cannot get the complete support of my app on IE 11...
Let me know ;-)
The text was updated successfully, but these errors were encountered: