Instance status configuration

[paolodamico]

Changes

• You can now configure your instance through PostHog's UI.
• Closes Email setup from the PostHog app charts-clickhouse#114

Nice confirmation screen before saving

Warning when changing recordings TTL (@rcmarron)

Info when changing email settings

How did you test this code?

• Open the instance settings page with your user is_staff = True.
• Test updating single setting.
• Test updating multiple settings.
• Test updating boolean, number & string values.

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

[Twixes]

This is great! Just a few rough edges

[Twixes]

I would not have guessed that this is reachable from this button:

Perhaps it should be renamed from "System status" to "Manage instance"? (though seems like this will require making SitePopover 1 rem wide)

[paolodamico]

Well as we now have an additional menu item if the user is staff, I think it's fine to keep this way. If you're accessing the page from the site popover, it makes sense that you want to focus on the system status.

[Twixes]

Ah, honestly I didn't notice the sidebar button. This raises more questions – it's kind of weird:

• there are now two buttons that take you to this page – one in the sidebar, and one in the popover
• the sidebar button takes you to instance settings… but that's the third tab of the page, not the first, which is a surprising destination for a pattern that's meant for top-level pages
• "Settings" is just one of a few tabs – a sidebar item should cover all tabs of the page it leads too (otherwise the highlighting is confusing when you navigate to another page tab for example)

If we go the sidebar item route, I strongly propose making instance settings their own page, with status/metrics reachable from the popover like it is currently.

[paolodamico]

Thanks for the thorough review @Twixes, all feedback addressed, ready for a final look.

[Twixes]

All good except got some doubts about the navigation patterns in use

[Twixes]

Ah, honestly I didn't notice the sidebar button. This raises more questions – it's kind of weird:

• there are now two buttons that take you to this page – one in the sidebar, and one in the popover
• the sidebar button takes you to instance settings… but that's the third tab of the page, not the first, which is a surprising destination for a pattern that's meant for top-level pages
• "Settings" is just one of a few tabs – a sidebar item should cover all tabs of the page it leads too (otherwise the highlighting is confusing when you navigate to another page tab for example)

If we go the sidebar item route, I strongly propose making instance settings their own page, with status/metrics reachable from the popover like it is currently.

[paolodamico]

Thanks @Twixes! Alright I've decided just to rename the page to make it consistent, and the sidebar link now opens the first tab. We can iterate later if it makes sense.

[clarkus]

This PR resulted in adding an instance level navigation item to the project navigation. By design, everything in that menu should be project navigation. We already link to this via the utilities menu. Likewise a lot of the modals, banners, etc are using really long form values and they don't align to our other components of the same type.