.github/workflows/ci-backend.yml: fix flake8 config #8676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzadous
approved these changes
Feb 18, 2022
EDsCODE
added a commit
that referenced
this pull request
Feb 18, 2022
* master: hobby: Wait for ClickHouse and for Postgres before starting (#8686) Part 2: Deprecate old tags and upgrade to new tags Backend (#8529) Remove flake8-commas (#8695) Update Breakdown props to use filter groups (#8679) Automatically switch to the right project if possible (#8681) Super Lazy VMs (#8609) .github/workflows/ci-backend.yml: fix flake8 config (#8676) Fix recording page refresh loop (#8685) Instance status configuration (#8096)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With #8675 and #8671 we've made explicit linting rule sets to exclude for
flake8.Despite an error in the first PR, we weren't able to catch it in CI as we are using a different configuration to run
flake8.I think CI should use the same rule set we use for pre-commit hooks
How did you test this code?
flake8 .