Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Item Preview is not clickable #394

Closed
ryzech opened this issue Sep 3, 2023 · 6 comments
Closed

[BUG] Item Preview is not clickable #394

ryzech opened this issue Sep 3, 2023 · 6 comments
Labels
bug Something isn't working todo

Comments

@ryzech
Copy link

ryzech commented Sep 3, 2023

Description

While using quickshop over the past few weeks, something broke and yesterday the item preview stopped working, unsure what the cause is as i didn’t change anything in the config afaik.

Steps to reproduce

  1. Left click shop sign
  2. Try to click on item preview text
  3. Nothing happens

Expected Behaviour

Quick shop should show the preview when the text is clicked

Screenshots

IMG_4542

/qs paste URL

https://paste.helpch.at/yawixisubi

Additional Context

No response
@evnrca
Copy link

evnrca commented Sep 3, 2023

UP! i have the same issue. i already try resetting the config to defult.

@sandtechnology sandtechnology added bug Something isn't working todo labels Sep 6, 2023
@madebygood
Copy link

wating....

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. Please use English next time.

waiting....

sandtechnology added a commit that referenced this issue Sep 18, 2023
@sandtechnology
#394 Fix wrong event format copying after SPIGOT-7091: Update bungeec…
5941646 
…ord-chat

Introduce by https://github.com/SpigotMC/BungeeCord/pull/3344/files#diff-84a270b9ce33820f05d3564ab384e29478185dd8302836fbdc17ec17cd04b949R164
We use our own method to just press event, no sure if this should be open a pull request to upstream
@sandtechnology
Copy link

https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2537/artifact/target/QuickShop-5.1.2.3-SNAPSHOT.jar
How about this version?

sandtechnology added a commit that referenced this issue Sep 18, 2023
@sandtechnology @crowdin-bot
5.1.2.3 (#400)
d5b729a 
* New Crowdin translations by Github Action

* [1.20.x] Cancel for interacting with sign (editing)

* [1.20.x] Cancel for all player interacting with sign (editing)

* Bump version to 5.1.2.3

* Fix dbPrefix issue when using convert command

* Fix dbPrefix not handling none when using convert command

* Fix build

* Fix build again

* Fix message for wrong displaying to owning shops in transfer

* #394 Fix wrong event format copying after SPIGOT-7091: Update bungeecord-chat
Introduce by https://github.com/SpigotMC/BungeeCord/pull/3344/files#diff-84a270b9ce33820f05d3564ab384e29478185dd8302836fbdc17ec17cd04b949R164
We use our own method to just press event, no sure if this should be open a pull request to upstream

* Fix errors for pre spigot chat lib update

* #395 update advanced-region-market deps to 3.5.4

* Bump com.github.angeschossen:LandsAPI from 6.29.12 to 6.35.0 (#399)

Bumps com.github.angeschossen:LandsAPI from 6.29.12 to 6.35.0.

---
updated-dependencies:
- dependency-name: com.github.angeschossen:LandsAPI
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.sk89q.worldguard:worldguard-bukkit from 7.0.8 to 7.0.9 (#398)

Bumps com.sk89q.worldguard:worldguard-bukkit from 7.0.8 to 7.0.9.

---
updated-dependencies:
- dependency-name: com.sk89q.worldguard:worldguard-bukkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.comphenix.protocol:ProtocolLib from 5.0.0 to 5.1.0 (#396)

Bumps com.comphenix.protocol:ProtocolLib from 5.0.0 to 5.1.0.

---
updated-dependencies:
- dependency-name: com.comphenix.protocol:ProtocolLib
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump org.junit.jupiter:junit-jupiter-api from 5.9.2 to 5.10.0 (#387)

Bumps [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5) from 5.9.2 to 5.10.0.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.2...r5.10.0)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.github.alex9849:advanced-region-market from 3.5.0 to 3.5.4 (#386)

Bumps com.github.alex9849:advanced-region-market from 3.5.0 to 3.5.4.

---
updated-dependencies:
- dependency-name: com.github.alex9849:advanced-region-market
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* New Crowdin translations by Github Action (#370)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
@sandtechnology sandtechnology mentioned this issue Sep 18, 2023
Merged
sandtechnology added a commit that referenced this issue Sep 18, 2023
@sandtechnology @crowdin-bot
5.1.2.3 (#400) (#401)
b8b406b 
* New Crowdin translations by Github Action

* [1.20.x] Cancel for interacting with sign (editing)

* [1.20.x] Cancel for all player interacting with sign (editing)

* Bump version to 5.1.2.3

* Fix dbPrefix issue when using convert command

* Fix dbPrefix not handling none when using convert command

* Fix build

* Fix build again

* Fix message for wrong displaying to owning shops in transfer

* #394 Fix wrong event format copying after SPIGOT-7091: Update bungeecord-chat
Introduce by https://github.com/SpigotMC/BungeeCord/pull/3344/files#diff-84a270b9ce33820f05d3564ab384e29478185dd8302836fbdc17ec17cd04b949R164
We use our own method to just press event, no sure if this should be open a pull request to upstream

* Fix errors for pre spigot chat lib update

* #395 update advanced-region-market deps to 3.5.4

* Bump com.github.angeschossen:LandsAPI from 6.29.12 to 6.35.0 (#399)

Bumps com.github.angeschossen:LandsAPI from 6.29.12 to 6.35.0.

---
updated-dependencies:
- dependency-name: com.github.angeschossen:LandsAPI
  dependency-type: direct:production
  update-type: version-update:semver-minor
...




* Bump com.sk89q.worldguard:worldguard-bukkit from 7.0.8 to 7.0.9 (#398)

Bumps com.sk89q.worldguard:worldguard-bukkit from 7.0.8 to 7.0.9.

---
updated-dependencies:
- dependency-name: com.sk89q.worldguard:worldguard-bukkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...




* Bump com.comphenix.protocol:ProtocolLib from 5.0.0 to 5.1.0 (#396)

Bumps com.comphenix.protocol:ProtocolLib from 5.0.0 to 5.1.0.

---
updated-dependencies:
- dependency-name: com.comphenix.protocol:ProtocolLib
  dependency-type: direct:production
  update-type: version-update:semver-minor
...




* Bump org.junit.jupiter:junit-jupiter-api from 5.9.2 to 5.10.0 (#387)

Bumps [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5) from 5.9.2 to 5.10.0.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.2...r5.10.0)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-type: direct:development
  update-type: version-update:semver-minor
...




* Bump com.github.alex9849:advanced-region-market from 3.5.0 to 3.5.4 (#386)

Bumps com.github.alex9849:advanced-region-market from 3.5.0 to 3.5.4.

---
updated-dependencies:
- dependency-name: com.github.alex9849:advanced-region-market
  dependency-type: direct:production
  update-type: version-update:semver-patch
...




* New Crowdin translations by Github Action (#370)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
@madebygood
Copy link

when click the sign(try trade)
image

@ryzech
Copy link
Author

ryzech commented Oct 16, 2023

Seems to be fixed, at least on my server (Purpur 1.20.2 build 2081). Will close for now. Thank you!

@ryzech ryzech closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sandtechnology @madebygood @ryzech @Issues-translate-bot @evnrca