Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] AdvancedRegionMarket integration doesn't work #395

Closed
Bloodlex opened this issue Sep 3, 2023 · 3 comments
Closed

[BUG] AdvancedRegionMarket integration doesn't work #395

Bloodlex opened this issue Sep 3, 2023 · 3 comments
Labels
bug Something isn't working todo wontfix This will not be worked on

Comments

@Bloodlex
Copy link

Bloodlex commented Sep 3, 2023

Description

After expiring the region, advancedregionmarket integration doesn't delete shops.

Steps to reproduce

  1. Create an ARM region with shops.
  2. Expire or unsell the region.
  3. Shops are still there although integration is enabled.

Expected Behaviour

Shops should be deleted.

Screenshots

None

/qs paste URL

https://paste.helpch.at/bahurileya

Additional Context

None
@sandtechnology
Copy link

It's caused by changed api from AdvancedRegionMarket side, will investigate it later

@sandtechnology sandtechnology added bug Something isn't working todo labels Sep 6, 2023
sandtechnology added a commit that referenced this issue Sep 18, 2023
@sandtechnology
#395 update advanced-region-market deps to 3.5.4
55d9766
@sandtechnology
Copy link

https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2539/artifact/target/QuickShop-5.1.2.3-SNAPSHOT.jar
This build should fix it

sandtechnology added a commit that referenced this issue Sep 18, 2023
@sandtechnology @crowdin-bot
5.1.2.3 (#400)
d5b729a 
* New Crowdin translations by Github Action

* [1.20.x] Cancel for interacting with sign (editing)

* [1.20.x] Cancel for all player interacting with sign (editing)

* Bump version to 5.1.2.3

* Fix dbPrefix issue when using convert command

* Fix dbPrefix not handling none when using convert command

* Fix build

* Fix build again

* Fix message for wrong displaying to owning shops in transfer

* #394 Fix wrong event format copying after SPIGOT-7091: Update bungeecord-chat
Introduce by https://github.com/SpigotMC/BungeeCord/pull/3344/files#diff-84a270b9ce33820f05d3564ab384e29478185dd8302836fbdc17ec17cd04b949R164
We use our own method to just press event, no sure if this should be open a pull request to upstream

* Fix errors for pre spigot chat lib update

* #395 update advanced-region-market deps to 3.5.4

* Bump com.github.angeschossen:LandsAPI from 6.29.12 to 6.35.0 (#399)

Bumps com.github.angeschossen:LandsAPI from 6.29.12 to 6.35.0.

---
updated-dependencies:
- dependency-name: com.github.angeschossen:LandsAPI
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.sk89q.worldguard:worldguard-bukkit from 7.0.8 to 7.0.9 (#398)

Bumps com.sk89q.worldguard:worldguard-bukkit from 7.0.8 to 7.0.9.

---
updated-dependencies:
- dependency-name: com.sk89q.worldguard:worldguard-bukkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.comphenix.protocol:ProtocolLib from 5.0.0 to 5.1.0 (#396)

Bumps com.comphenix.protocol:ProtocolLib from 5.0.0 to 5.1.0.

---
updated-dependencies:
- dependency-name: com.comphenix.protocol:ProtocolLib
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump org.junit.jupiter:junit-jupiter-api from 5.9.2 to 5.10.0 (#387)

Bumps [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5) from 5.9.2 to 5.10.0.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.2...r5.10.0)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.github.alex9849:advanced-region-market from 3.5.0 to 3.5.4 (#386)

Bumps com.github.alex9849:advanced-region-market from 3.5.0 to 3.5.4.

---
updated-dependencies:
- dependency-name: com.github.alex9849:advanced-region-market
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* New Crowdin translations by Github Action (#370)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
@sandtechnology sandtechnology mentioned this issue Sep 18, 2023
Merged
sandtechnology added a commit that referenced this issue Sep 18, 2023
@sandtechnology @crowdin-bot
5.1.2.3 (#400) (#401)
b8b406b 
* New Crowdin translations by Github Action

* [1.20.x] Cancel for interacting with sign (editing)

* [1.20.x] Cancel for all player interacting with sign (editing)

* Bump version to 5.1.2.3

* Fix dbPrefix issue when using convert command

* Fix dbPrefix not handling none when using convert command

* Fix build

* Fix build again

* Fix message for wrong displaying to owning shops in transfer

* #394 Fix wrong event format copying after SPIGOT-7091: Update bungeecord-chat
Introduce by https://github.com/SpigotMC/BungeeCord/pull/3344/files#diff-84a270b9ce33820f05d3564ab384e29478185dd8302836fbdc17ec17cd04b949R164
We use our own method to just press event, no sure if this should be open a pull request to upstream

* Fix errors for pre spigot chat lib update

* #395 update advanced-region-market deps to 3.5.4

* Bump com.github.angeschossen:LandsAPI from 6.29.12 to 6.35.0 (#399)

Bumps com.github.angeschossen:LandsAPI from 6.29.12 to 6.35.0.

---
updated-dependencies:
- dependency-name: com.github.angeschossen:LandsAPI
  dependency-type: direct:production
  update-type: version-update:semver-minor
...




* Bump com.sk89q.worldguard:worldguard-bukkit from 7.0.8 to 7.0.9 (#398)

Bumps com.sk89q.worldguard:worldguard-bukkit from 7.0.8 to 7.0.9.

---
updated-dependencies:
- dependency-name: com.sk89q.worldguard:worldguard-bukkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...




* Bump com.comphenix.protocol:ProtocolLib from 5.0.0 to 5.1.0 (#396)

Bumps com.comphenix.protocol:ProtocolLib from 5.0.0 to 5.1.0.

---
updated-dependencies:
- dependency-name: com.comphenix.protocol:ProtocolLib
  dependency-type: direct:production
  update-type: version-update:semver-minor
...




* Bump org.junit.jupiter:junit-jupiter-api from 5.9.2 to 5.10.0 (#387)

Bumps [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5) from 5.9.2 to 5.10.0.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.2...r5.10.0)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-type: direct:development
  update-type: version-update:semver-minor
...




* Bump com.github.alex9849:advanced-region-market from 3.5.0 to 3.5.4 (#386)

Bumps com.github.alex9849:advanced-region-market from 3.5.0 to 3.5.4.

---
updated-dependencies:
- dependency-name: com.github.alex9849:advanced-region-market
  dependency-type: direct:production
  update-type: version-update:semver-patch
...




* New Crowdin translations by Github Action (#370)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
@stale Stale
Copy link

stale bot commented Nov 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 18, 2023
@stale stale bot closed this as completed Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working todo wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bloodlex @sandtechnology