Tap changer extrema strategy behavior #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test cases to verify the behavior of the min_voltage_tap and max_voltage_tap strategies when the entire voltage band range falls outside the achievable voltage range. The tests ensure that these strategies return the tap position that results in the minimum or maximum achievable voltage, even when regulation within the target band is impossible.
Key Changes
- Added test cases for
min_voltage_tapstrategy when achievable voltages are below or above the band - Added test cases for
max_voltage_tapstrategy when achievable voltages are below or above the band - Test data includes input configurations, expected output, and calculation parameters
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-below-band-min/* |
Test case for min strategy when achievable voltage is below the minimum band threshold |
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-below-band-max/* |
Test case for max strategy when achievable voltage is below the maximum band threshold |
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-min/* |
Test case for min strategy when achievable voltage is above the minimum band threshold |
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-max/* |
Test case for max strategy when achievable voltage is above the maximum band threshold |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-below-band-min/input.json
Show resolved
Hide resolved
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-below-band-max/input.json
Show resolved
Hide resolved
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-min/input.json
Outdated
Show resolved
Hide resolved
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-max/input.json
Show resolved
Hide resolved
2 tasks
… any Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
figueroa1395
reviewed
Dec 9, 2025
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-any/output.json
Outdated
Show resolved
Hide resolved
figueroa1395
reviewed
Dec 9, 2025
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-any/params.json
Show resolved
Hide resolved
figueroa1395
reviewed
Dec 9, 2025
...s/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-fast-any/params.json
Outdated
Show resolved
Hide resolved
figueroa1395
reviewed
Dec 9, 2025
...s/data/power_flow/automatic-tap-regulator/achievable-voltage-below-band-fast-any/params.json
Outdated
Show resolved
Hide resolved
mgovers
reviewed
Dec 9, 2025
tests/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-any/output.json
Outdated
Show resolved
Hide resolved
...s/data/power_flow/automatic-tap-regulator/achievable-voltage-above-band-fast-any/params.json
Outdated
Show resolved
Hide resolved
...s/data/power_flow/automatic-tap-regulator/achievable-voltage-below-band-fast-any/params.json
Outdated
Show resolved
Hide resolved
Member
|
oh i see santiago also reviewed and some are duplicate as a result. will resolve the strictly duplicate ones and leave open the suggestion ones |
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…ge-above-band-min/input.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…ttps://github.com/PowerGridModel/power-grid-model into investigation/tap-changer-extrema-strategy-behavior
|
mgovers
approved these changes
Dec 9, 2025
figueroa1395
approved these changes
Dec 9, 2025
Jerry-Jinfeng-Guo
deleted the
investigation/tap-changer-extrema-strategy-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases to verify the
minandmaxtap changing strategy would actually return a tap that results in a minimum or maximum voltage even in the case of the whole voltage band range falls outside achievable voltage ranges. The same hold for theanystrategy. This edge case is found to be a bug forfast_any.