Update ContainerRegistry dependency parsing logic to account for Az packages named Az* #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
Feb 12, 2025
src/code/PSResourceInfo.cs
Outdated
| @@ -972,7 +972,7 @@ public static bool TryConvertFromContainerRegistryJson( | |||
| metadata["Dependencies"] = ParseContainerRegistryDependencies(requiredModulesElement, out errorMsg).ToArray(); | |||
| } | |||
|
|
|||
| if (string.Equals(packageName, "Az", StringComparison.OrdinalIgnoreCase) || packageName.StartsWith("Az.", StringComparison.OrdinalIgnoreCase)) | |||
| if (packageName.StartsWith("Az", StringComparison.OrdinalIgnoreCase)) | |||
There was a problem hiding this comment.
I would prefer explicitly adding AzPreview. Otherwise it might match other modules like azereo, AzDOCmd, AzFnUtil etc.
There was a problem hiding this comment.
Though these modules are not on MAR, this code is going to be shared with ACR.
There was a problem hiding this comment.
Also add a test for AzPreview
alerickson
approved these changes
Feb 12, 2025
adityapatwardhan
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consuming a package from a container registry, we have a certain logic to look for the package's dependencies. For Az* packages the dependencies are in
ModuleListand that criteria logic needs to be updated.PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.