Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ContainerRegistry dependency parsing logic to account for Az packages named Az* #1790

Closed
wants to merge 3 commits into from
Closed

Update ContainerRegistry dependency parsing logic to account for Az packages named Az* #1790

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85ae55c
Update Dependency parsing logic to account for Az packages with Az* n…
anamnavi Feb 12, 2025
53562a4
specify Azpreview explicitly in condition
anamnavi Feb 12, 2025
d175eaa
add test for Azpreview from MAR
anamnavi Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/code/PSResourceInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,7 @@ public static bool TryConvertFromContainerRegistryJson(
metadata["Dependencies"] = ParseContainerRegistryDependencies(requiredModulesElement, out errorMsg).ToArray();
}

if (string.Equals(packageName, "Az", StringComparison.OrdinalIgnoreCase) || packageName.StartsWith("Az.", StringComparison.OrdinalIgnoreCase))
if (packageName.StartsWith("Az", StringComparison.OrdinalIgnoreCase))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer explicitly adding AzPreview. Otherwise it might match other modules like azereo, AzDOCmd, AzFnUtil etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though these modules are not on MAR, this code is going to be shared with ACR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a test for AzPreview

{
if (rootDom.TryGetProperty("ModuleList", out JsonElement moduleListDepsElement))
{
Expand Down