Add completion single/double quote support for -Noun parameter

[ArmaanMcleod]

PR Summary

Use CompletionCompleters.GetMatchingResults in NounArgumentCompleter so -Noun parameter for Get-Command has support for single/double quotes.

Also made the following improvements:

• When -Verb is used, only get nouns which are possible with the following verbs.
• use SortedSet<string> with StringComparer.IgnoreCase to ensure all nouns are unique and sorted and case insensitive. Also removed previous LINQ Order() call with this change.
• Wrap Get-Command logic into CompletionCompleters.GetCommandInfo method. This can probably be used elsewhere and potentially reduce duplication of command querying code in completers. Also add using for creating powershell instance so its automatically disposed.

I also added some tab completion tests which seem to be missing for this completer.

PR Context

Related to #24873

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    - [ ] Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
      (which runs in a different PS Host).
      • Issue filed:
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Issue filed:
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Issue filed:
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
      • Issue filed:

[iSazonov]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[iSazonov]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[iSazonov]

@ArmaanMcleod Please look failed tests. It seems previously had fake ordering for CompletionResult type.

[ArmaanMcleod]

@iSazonov It looks like tests need to exclude Gridview cmdlets for Mac and Linux, hench test failures. These cmdlets only available on Windows.

I will fix this.

[iSazonov]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[ArmaanMcleod]

@iSazonov I think it should be fine now. Thanks for the help.

I ran tests on Windows and Linux and it seems to be fine, hoping CI lets it go through 😄.

[iSazonov]

If cmdlet names are case-insensetive on all OS-s this must be case-insensetive too. I think we should think about fixing tests only.

[ArmaanMcleod]

Yep I agree, although to completer it does not make a difference. I have updated code & test. Only way is to use sorted set in the test becauseSort-Object -Unique gives different ordering on Linux. I think this is fine because it is an accurate comparison anyways.

[microsoft-github-policy-service]

📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Microsoft Forms