Skip to content

Add capabilities data to InitializeResponse body in debug adapter #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue Feb 19, 2016 · 2 comments
Closed

Add capabilities data to InitializeResponse body in debug adapter #164

daviwil opened this issue Feb 19, 2016 · 2 comments
Assignees
@rkeithhill
Labels
Issue-Enhancement A feature request (enhancement).
Milestone
0.5.0

Comments

@daviwil
Copy link
Contributor

daviwil commented Feb 19, 2016

The VS Code team has added a capabilities list that our debug adapter can opt into:

https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/common/debugProtocol.d.ts#L495

In the following issue, Isidor recommended that we set the supportsEvaluateForHovers to true so that data tips are evaluated correctly. We should also determine which other capabilities we'd like to support and file separate issues for enabling those.

Related: microsoft/vscode#1804
@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Feb 19, 2016
@daviwil daviwil added this to the 0.5.0 milestone Feb 19, 2016
@rkeithhill
Copy link
Contributor

We should add support for this one as well: supportsConditionalBreakpoints.

@daviwil
Copy link
Contributor Author

daviwil commented Feb 19, 2016

Yep, we'll take care of that in this issue: #94

@rkeithhill rkeithhill self-assigned this Feb 24, 2016
daviwil added a commit that referenced this issue Feb 25, 2016
@daviwil
Merge pull request #168 from rkeithhill/rkeithhill/is164-initialize-c…
1b4eff0 
…apabilities

Fixes #164 - adds capabilities response to initialize request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkeithhill rkeithhill

Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@daviwil @rkeithhill