Skip to content

Fixes #164 - adds capabilities response to initialize request. #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rkeithhill
Copy link
Contributor

This commit is in preparation for adding conditional breakpoint and function breakpoint support. Also cleaned up some doc comments. The two primary files that were changed functionally are InitializeRequest.cs and DebugAdapaterBase.cs.

This commit is in preparation for adding conditional breakpoint and function breakpoint support.  Also cleaned up some doc comments.  The two primary files that were changed functionally are InitializeRequest.cs and DebugAdapaterBase.cs.
…pe (object) wasn't right and I don't think we would ever support this unless the PowerShell debug engine started to support this.
@@ -17,25 +17,43 @@ public static readonly

public class LaunchRequestArguments
{
// /** An absolute path to the program to debug. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those!

@daviwil
Copy link
Contributor

daviwil commented Feb 25, 2016

Damn, didn't see the notification for this last night, sorry about that. Looks great!

daviwil added a commit that referenced this pull request Feb 25, 2016
…apabilities

Fixes #164 - adds capabilities response to initialize request.
@daviwil daviwil merged commit 1b4eff0 into PowerShell:master Feb 25, 2016
@rkeithhill rkeithhill deleted the rkeithhill/is164-initialize-capabilities branch February 25, 2016 17:43
@rkeithhill
Copy link
Contributor Author

Thanks. I want to start looking at both conditional and function breakpoints next. Given PowerShell's support for this, I think we can get also get VS style action breakpoints. :-)

@daviwil
Copy link
Contributor

daviwil commented Feb 25, 2016

That will be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants