Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Setting: Remember Terminal Status #1968

Closed
JustinGrote opened this issue May 20, 2019 · 4 comments
Closed

User Setting: Remember Terminal Status #1968

JustinGrote opened this issue May 20, 2019 · 4 comments
Labels
Area-Configuration Feature: VS Code Request to use or implement a VS Code feature.

Comments

@JustinGrote
Copy link
Collaborator

Summary of the new feature

User Setting to not automatically reopen terminal on reload

Proposed technical implementation details (optional)

A user setting, terminal.integrated.RememberTerminalState, that will prevent the integrated terminal from reopening if it was already closed, even if the terminal window is visible at time of reload

Currently, when using the powershell extension, even if you have the "native" terminal closed and only had the Powershell Integrated Console open, if you issue a "Reload Window" command, the native terminal comes back, in addition to the integrated console, and both load at the same time. This has the effect of adding a lot of CPU to the startup time (and consequently several seconds) as both consoles are started.

This doesn't happen if the terminal pane was not visible at the time of reload.

This is related to #580, but that is the opposite problem: Remembering the status of the Powershell Integrated Terminal. It can be used as an implementation reference.

@TylerLeonhardt
Copy link
Member

Hi @JustinGrote can you try using this setting:

"powershell.integratedConsole.showOnStartup": false

@JustinGrote
Copy link
Collaborator Author

JustinGrote commented May 24, 2019 via email

@rjmholt
Copy link
Contributor

rjmholt commented May 24, 2019

Ah right -- yeah I think that's most appropriate in the VSCode repo. I looked for a configuration on that briefly, but couldn't find one

@SydneyhSmith SydneyhSmith added Triage Feature: VS Code Request to use or implement a VS Code feature. Area-Configuration and removed Needs-Repro-Info Needs: Fix Verification Please verify the fix for us! labels May 28, 2019
@SydneyhSmith
Copy link
Collaborator

Going to close this, as it needs to be done on the VSCode end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Configuration Feature: VS Code Request to use or implement a VS Code feature.
Projects
None yet
Development

No branches or pull requests

4 participants