Fix a handful of issues with PowerShell sessions #793
Conversation
| $errorString = "" | ||
|
|
||
| while ($e -ne $null) { | ||
| $errorString = $errorString + ($e.Message + "`r`n" + $e.StackTrace + "`r`n") | ||
| $e = $e.InnerException; | ||
| } | ||
|
|
||
| ExitWithError ("Caught error while waiting for EditorServicesHost to complete:`r`n" + $errorString) | ||
| ExitWithError ("A terminating error occurred in PowerShell Editor Services:`r`n`r`n" + $errorString) | ||
| } |
There was a problem hiding this comment.
Good call on eliminating the signature for this script. I've had several issues with folks using PSCX after we started signing the scripts.
There was a problem hiding this comment.
This was only temporary since the signature isn't valid after the script contents have changed. Why did signing the startup script cause issues for PSCX? Maybe it's an indication of some other issue that I haven't seen before
There was a problem hiding this comment.
Folks that were offline ran into an apparent hang as the CRL check takes several minutes to come back IIRC. It is somewhat rare I think because if the system has ever been on the internet it gets a CRL it can check.
There was a problem hiding this comment.
Hmmm... That could explain a complaint I've been seeing from some folks who report that the extension doesn't start up for them if they're offline due to internet not being accessible at the moment (like on a train). Was it a combination of PSCX and the signed script that caused it, or just the signed script itself?
Now that the PowerShell Editor Services has a Folding Provider, this extension based feature is no longer required. This commit removes the feature and tests. The PSES Issue PowerShell#793 [1] tracks the work to add it to PSES. [1] PowerShell/PowerShellEditorServices#793
No description provided.