Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

White segment separators on the left side #948

Closed
nitwof opened this issue Aug 9, 2018 · 4 comments
Closed

White segment separators on the left side #948

nitwof opened this issue Aug 9, 2018 · 4 comments

Comments

@nitwof
Copy link

nitwof commented Aug 9, 2018

Describe Your Issue

I was using non-standard colors like mediumpurple4 or grey11 and get white segment separators on the left side.

screen shot 2018-08-09 at 22 29 28

Have you tried to debug or fix it?

I've found that issue comes from using variable $CURRENT_BG as foreground color directly without converting it to color id through foregroundColor function.
https://github.com/bhilburn/powerlevel9k/blob/571a859413866897cf962396f02f65a288f677ac/powerlevel9k.zsh-theme#L134
https://github.com/bhilburn/powerlevel9k/blob/571a859413866897cf962396f02f65a288f677ac/powerlevel9k.zsh-theme#L183

Environment Information

  • ZSH version: 5.1.1
  • Frameworks: Antigen and Oh-My-ZSH
  • P9k install: through Antigen
  • P9k version: v0.6.5
  • Terminal emulator: iTerm2
nitwof added a commit to nitwof/powerlevel9k that referenced this issue Aug 9, 2018
@dritter
Copy link
Member

dritter commented Aug 9, 2018

Hi @Nightwolf007 !

We already have a fix for that in our preparation branch #944 for the upcoming version. It would be super helpful, if you could try out this branch and report any issues.

Thx

@nitwof
Copy link
Author

nitwof commented Aug 9, 2018

Hi @dritter !
Thank you for reply.

I've checked preparation branch. It fixes this issue.
But i noticed, that custom foreground color is not working on the right pane. I think it comes from here:
https://github.com/dritter/powerlevel9k/blob/a0d57bc455e654ba688d108219bd254863bca438/powerlevel9k.zsh-theme#L234
I think there should be foregroundColor variable.

@dritter
Copy link
Member

dritter commented Aug 9, 2018

Ha! Awesome catch! I forgot to rename that variable. Fixed it.

@nitwof
Copy link
Author

nitwof commented Aug 9, 2018

Thanks! I will close the issue then.

@nitwof nitwof closed this as completed Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants