Prepare 066 #944

dritter · 2018-08-05T23:00:41Z

This is a preparation for v0.6.6.

The following PRs are incorporated in here:

Add tests #934 - Add Tests
test-in-docker: fix with newer ZSH versions #884 - test-in-docker: fix with newer ZSH versions
[Docs] Add etc state description in dir docs #928 - [Docs] Add etc state description in dir docs
Use SUDO_COMMAND to check for sudo #937 - Use SUDO_COMMAND to check for sudo
[Bugfix] Resolve #918 Transparent background #925 - [Bugfix] Resolve Transparent background broke #918 Transparent background
Fix font issue debugging script #923 - Fix font issue debugging script
OS_ICON segment separator issue #921 - Add missing colors to fix color comparison
Add fallback icon for linux distros #951 - Add fallback icon for missing linux distro icons
Fix broken link in README referencing date and time configuration #956 - Fix broken link in readme

Bugs fixed

What's not included in this PR

Still no "real" fix for [Bug] Duplicate Color Codes #825

The way I was filtering out entries in the frameworks array stopped working in newer versions of ZSH; it would convert the array into a string (you could see it with `typeset -p frameworks`) So I rewrote it. I don't see anything in the release notes for ZSH that would explain this and I didn't find any option that would restore this behavior. Related: Powerlevel9k#882

Marking variables as readonly is helpful for debugging and preventing problems.

Additionally - Add a fourth parameter to prompt_battery for better testability. This parameter is the root prefix, so we can use our own test batteries.

Change regular expressions to a more compatible format.

onaforeignshore · 2018-08-09T09:08:59Z

#937 was applied to context but not to user segments

onaforeignshore · 2018-08-09T09:30:54Z

powerlevel9k.zsh-theme

@@ -189,7 +189,7 @@ left_prompt_segment() {
 # End the left prompt, closes the final segment.
 left_prompt_end() {
  if [[ -n $CURRENT_BG ]]; then
-    echo -n "%k%F{$CURRENT_BG}$(print_icon 'LEFT_SEGMENT_SEPARATOR')"
+    echo -n "%k$(foregroundColor ${CURRENT_BG})$(print_icon 'LEFT_SEGMENT_SEPARATOR')"


$CURRENT_BG will contain a numeric, since getColorCode was already called in left_prompt_segment. Do we really have to add another function call to slow the prompt down more?

Yes, $CURRENT_BG is already numeric. I made this change anyway, to match up with the other occurrences of foreground color. To go full nuts I removed the possibility to stop an fore/background color with a call to that method without params.

In an upcoming release we should either go all in with helper methods for getting a prepared string that contains "start a foreground color", or nothing. I am undecided between the two ways. In another programming language I would prefer a helper method that wraps a cryptic DSL to a nice interface, but here I would indeed prefer going for speed and not call a subshell for that. We should think about a concept for that.

`sudo -n true` only checks that we _could_ use `sudo`, not if we are in a sudo session. closes Powerlevel9k#852

Slabity · 2018-08-10T16:00:22Z

Just tested this on my system. Colors seem to be working just fine.

However, I did notice something else. Despite setting POWERLEVEL9K_HOME_ICON='\uf015' to change my home folder icon, the tilde in the directory still exists. Same with POWERLEVEL9K_FOLDER_ICON. Is that expected?

dritter · 2018-08-10T16:10:36Z

Thx for testing @Slabity .
Yep that is intentional. You can set POWERLEVEL9K_DIR_OMIT_FIRST_CHARACTER=true, to get rid of the first character.

Fix broken link referencing zsh date and time configuration in prompt expansion. The current broken link points to `http://zsh.sourceforge.net/Doc/Release Prompt-Expansion.html`, while the correct link is http://zsh.sourceforge.net/Doc/Release/Prompt-Expansion.html#Date-and-time

docwhat and others added 30 commits June 27, 2018 11:17

test-in-docker: add additional warnings

645034f

test-in-docker: make vars sorted and readonly

8986320

Marking variables as readonly is helpful for debugging and preventing problems.

test-in-docker: add dry-run mode

83abdf7

test-in-docker: lint from @dritter

3c27414

test-in-docker: resolve version and framework late

a94df3d

Add Dockerfiles for ZSH 5.3.1, 5.4.2, 5.5.1

20fdf05

Force creation of symlink in prezto

74051e5

Fixate ZSH versions in docker

b9e6e6f

Use ubuntu 17.10, as the sources for 17.04 seem to be down

0b92e91

Add Dockerfile for zshing framework

4178240

Execute tests on various ZSH versions

6c4a3e8

Test all *.spec files on travis

21f2d1a

Output running test

b996ca9

Add tests for anaconda segment

0e4e9e4

Add tests for aws_eb_env segment

8c44fa6

Add tests for background_jobs segment

74a3d2d

Add tests for battery segment

802af32

Additionally - Add a fourth parameter to prompt_battery for better testability. This parameter is the root prefix, so we can use our own test batteries.

Fix go_version test

d9b3edf

Add tests for context segment

743ddc1

Add visual identifier to custom segments

629d52a

Add tests for custom segment

829c7ce

Simplify detect_virt segment

b61d021

Add tests for detect_virt segment

edfd473

Add tests for disk_usage segment

a757607

Change ip segment so that the tests can be executed on OSX as well

4327241

Change regular expressions to a more compatible format.

Add tests for ip segment

1cf68e4

Change load segment to accept an optional root prefix for testability

04168cc

Add tests for load segment

2efbd7e

Add tests for node_version segment

85cc62b

Add test for bright colors

a0d57bc

onaforeignshore reviewed Aug 9, 2018

View reviewed changes

This was referenced Aug 9, 2018

White segment separators on the left side #948

Closed

Use SUDO_COMMAND to check for sudo #937

Closed

dritter and others added 4 commits August 9, 2018 23:20

Fix foreground colors in right prompt segments

52ce993

Merge branch 'fix_colors' into prepare_066

6daef84

Add tests for color comparisons with none colors

7a1319c

Use SUDO_COMMAND to check for sudo

3fb0383

`sudo -n true` only checks that we _could_ use `sudo`, not if we are in a sudo session. closes Powerlevel9k#852

Merge remote-tracking branch 'docwhat/pr/sudo-check' into prepare_066

2700cb4

dritter mentioned this pull request Aug 10, 2018

Clarify none background #950

Open

bhilburn mentioned this pull request Aug 11, 2018

[Bug] Duplicate Color Codes #825

Closed

eloo and others added 2 commits August 11, 2018 16:18

Add fallback icon for linux distros

34bf8ed

Merge remote-tracking branch 'eloo/master' into prepare_066

6e78f7e

This was referenced Aug 11, 2018

Add fallback icon for linux distros #951

Merged

right prompt color error #955

Closed

nnja and others added 2 commits August 16, 2018 22:33

Merge remote-tracking branch 'nnja/patch-1' into prepare_066

69c69b9

dritter mentioned this pull request Aug 17, 2018

Fix broken link in README referencing date and time configuration #956

Merged

bhilburn merged commit e207dec into Powerlevel9k:master Aug 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare 066 #944

Prepare 066 #944

dritter commented Aug 5, 2018 •

edited

Loading

onaforeignshore commented Aug 9, 2018

onaforeignshore Aug 9, 2018

dritter Aug 9, 2018

Slabity commented Aug 10, 2018

dritter commented Aug 10, 2018

Prepare 066 #944

Prepare 066 #944

Conversation

dritter commented Aug 5, 2018 • edited Loading

Bugs fixed

What's not included in this PR

onaforeignshore commented Aug 9, 2018

onaforeignshore Aug 9, 2018

Choose a reason for hiding this comment

dritter Aug 9, 2018

Choose a reason for hiding this comment

Slabity commented Aug 10, 2018

dritter commented Aug 10, 2018

dritter commented Aug 5, 2018 •

edited

Loading