Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add dbt core operation block #119

Merged
merged 26 commits into from
Feb 15, 2023
Merged

Add dbt core operation block #119

merged 26 commits into from
Feb 15, 2023

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Feb 2, 2023 •
edited
Loading

DbtCoreOperation inherits from prefect_shell's ShellOperation which has the trigger/wait_for_completion/fetch_result and run methods, and the additions are before triggering/running:

  1. managing profiles dir
  2. ensuring there's at least one dbt command
  3. appending profiles dir / projects dir to dbt commands

Closes

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@ahuang11 ahuang11 changed the title Add dbt core op Add dbt core operation block Feb 2, 2023
@ahuang11 ahuang11 marked this pull request as ready for review February 3, 2023 04:37
@ahuang11 ahuang11 requested a review from a team February 3, 2023 04:37
@ahuang11 ahuang11 requested a review from zzstoatzz February 3, 2023 23:20
desertaxle
desertaxle suggested changes Feb 10, 2023
View reviewed changes
@ahuang11 ahuang11 requested a review from desertaxle February 10, 2023 20:14
desertaxle
desertaxle previously approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahuang11
Sqlalchemy connector (#123)
6f6d4d3 
* Add support for sqlalchemy connector

* Update changelog and fix test

* Change warning

* Address comments

* Fix static anal

* FIx tests
@ahuang11 ahuang11 requested a review from desertaxle February 15, 2023 18:22
@ahuang11 ahuang11 merged commit 8477d0a into main Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahuang11 @desertaxle @zzstoatzz