Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Sqlalchemy connector #123

Merged
merged 11 commits into from
Feb 15, 2023
Merged

Sqlalchemy connector #123

merged 11 commits into from
Feb 15, 2023

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Feb 8, 2023 •
edited
Loading

Note: this is based off dbt_core_operation branch.

Adds support for SqlAlchemyConnector since DatabaseCredentials is deprecated.

Closes #116

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@ahuang11 ahuang11 marked this pull request as ready for review February 8, 2023 00:59
@ahuang11 ahuang11 requested a review from a team February 8, 2023 00:59
@ahuang11 ahuang11 requested a review from desertaxle February 10, 2023 20:22
desertaxle
desertaxle approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahuang11 ahuang11 merged commit 6f6d4d3 into dbt_core_operation Feb 15, 2023
ahuang11 added a commit that referenced this pull request Feb 15, 2023
@ahuang11
Add dbt core operation block (#119)
8477d0a 
* Add dbt core op

* Add tests

* Add changelog

* Add example

* Add load

* Add changelog and deprecation warning

* Update readme

* Update requirements

* Address comments

* Update type

* Add comment

* FIx tests

* Static anal

* Maybe fix 3.7 tests

* Fix windows test

* Fix Py 37 tests

* Another attempt

* fix windows test maybe

* Fix tests

* Fix windows test

* :( windows

* Sqlalchemy connector (#123)

* Add support for sqlalchemy connector

* Update changelog and fix test

* Change warning

* Address comments

* Fix static anal

* FIx tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desertaxle desertaxle desertaxle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahuang11 @desertaxle