set http2 to default false #161
Conversation
PrefectHQ/prefect#7442 encode/httpx#2112 considering that the above two issues mean that using `http2: false` leads consistently to irrecoverable worker failures, I think the default should be false
|
Hey there! Thanks for your pull request. There is a performance cost associated with this change, and the irrecoverable worker failures should be resolved with PrefectHQ/prefect#9267 Are you running the latest version of this chart? |
|
Hi @jawnsy , thanks for the quick response! I was about 2 weeks behind latest, which looks like right around when that PR was merged. I'll update that and let you know if the worker failures persist or not |
|
just wanted to update that I attempted to update the chart, but it causes the worker to fail in kube with Indeed this deployment does not exist. I'm not sure where it's getting that from or why it's trying to query that. moreover, the prefect UI shows the worker as healthy despite crashing repeatedly in kube anyway, I've reverted back to the chart from mar 10 and the above error as gone away. just setting |
|
This was an issue with an upstream dependency, which should have been resolved in encode/httpcore 0.17.1. I'm closing this out as the default behavior (to use HTTP/2) should now work reliably. Please let us know if you see otherwise after upgrading to the latest version. |
PrefectHQ/prefect#7442
encode/httpx#2112
considering that the above two issues mean that using
http2: trueleads consistently to irrecoverable worker failures, I think the default should be false