Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud storage recipe improvements #9145

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Cloud storage recipe improvements #9145

merged 3 commits into from
Apr 7, 2023

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Apr 7, 2023

While projects are in beta, we are looking for ways to improve the default experience of using recipes; in this case, when using either of the cloud based recipes, it's important that the push and pull step stay in sync with their bucket and folder references. Thanks to pull step templating, we can achieve this by default by referencing push step outputs in our pull step via templated variables.

This PR updates the cloud storage pull steps in our recipes to default to using a templated bucket and folder placeholder

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

@cicdw cicdw added the enhancement An improvement of an existing feature label Apr 7, 2023
@cicdw cicdw requested a review from desertaxle April 7, 2023 16:40
@cicdw cicdw requested a review from a team as a code owner April 7, 2023 16:40
@netlify
Copy link

netlify bot commented Apr 7, 2023

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 0a03bfb
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/6430478b7792770008f414a9
😎 Deploy Preview https://deploy-preview-9145--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cicdw cicdw merged commit 611e892 into main Apr 7, 2023
@cicdw cicdw deleted the aws-recipe branch April 7, 2023 16:46
asmundo pushed a commit to asmundo/prefect that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants