Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment defaults with project init #9146

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Update deployment defaults with project init #9146

merged 1 commit into from
Apr 7, 2023

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Apr 7, 2023

Similar to #9145 this PR updates recipe defaults to guide users to healthy deployments as quickly as possible. In this case, anytime a user uses a docker-based recipe, we default to using a job variable that references the image_name output of build_docker_image.

Example

Running prefect project init --recipe docker now produces the following work pool section:

work_pool:
  job_variables:
    image: '{{ image_name }}'
  name: null
  work_queue_name: null

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

@cicdw cicdw added the enhancement An improvement of an existing feature label Apr 7, 2023
@cicdw cicdw requested a review from desertaxle April 7, 2023 17:26
@cicdw cicdw requested a review from a team as a code owner April 7, 2023 17:26
@netlify
Copy link

netlify bot commented Apr 7, 2023

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit ffb66ec
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/643052577ee8c30008058000
😎 Deploy Preview https://deploy-preview-9146--prefect-docs-preview.netlify.app/api-ref/prefect/cli/root
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@serinamarie serinamarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cicdw cicdw merged commit c1222ec into main Apr 7, 2023
@cicdw cicdw deleted the default-image branch April 7, 2023 19:01
asmundo pushed a commit to asmundo/prefect that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants