Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cldice loss documentation #7193

Closed
wyli opened this issue Nov 3, 2023 · 0 comments · Fixed by #7271
Closed

cldice loss documentation #7193

wyli opened this issue Nov 3, 2023 · 0 comments · Fixed by #7271
Labels
Contribution wanted documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@wyli
Copy link
Contributor

wyli commented Nov 3, 2023

follow up of @jocpae in #5938 (comment), the relevant docstring should be reviewed and added to https://github.com/Project-MONAI/MONAI/blob/dev/docs/source/losses.rst?plain=1

please follow the instructions for changing the docs: https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#building-the-documentation

@wyli wyli added documentation Improvements or additions to documentation Contribution wanted good first issue Good for newcomers labels Nov 3, 2023
ytl0623 added a commit to ytl0623/MONAI that referenced this issue Nov 29, 2023
KumoLiu added a commit that referenced this issue Nov 30, 2023
…ion (#7271)

Fixes #7193

### Description
add SoftclDiceLoss and SoftDiceclDiceLoss loss function in
documentation(https://github.com/Project-MONAI/MONAI/blob/dev/docs/source/losses.rst?plain=1)

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: ytl0623 <david89062388@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
marksgraham pushed a commit to marksgraham/MONAI that referenced this issue Jan 30, 2024
…ion (Project-MONAI#7271)

Fixes Project-MONAI#7193

### Description
add SoftclDiceLoss and SoftDiceclDiceLoss loss function in
documentation(https://github.com/Project-MONAI/MONAI/blob/dev/docs/source/losses.rst?plain=1)

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: ytl0623 <david89062388@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this issue Mar 25, 2024
…ion (Project-MONAI#7271)

Fixes Project-MONAI#7193

### Description
add SoftclDiceLoss and SoftDiceclDiceLoss loss function in
documentation(https://github.com/Project-MONAI/MONAI/blob/dev/docs/source/losses.rst?plain=1)

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: ytl0623 <david89062388@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
…ion (Project-MONAI#7271)

Fixes Project-MONAI#7193

### Description
add SoftclDiceLoss and SoftDiceclDiceLoss loss function in
documentation(https://github.com/Project-MONAI/MONAI/blob/dev/docs/source/losses.rst?plain=1)

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: ytl0623 <david89062388@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution wanted documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant