-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request : please add cldice loss #5938
Comments
@wyli, can I work on implementing this? |
sure, I'm assigning this to you, thanks! |
Any update? |
no visible progress at the moment, unassigning this ticket... I saw a PR #6632 by @zilima but was closed now (would you still be interested in contributing? @zilima) |
Fixes #5938 ### Description This PR aims to add the `SoftclDiceLoss` and the `SoftDiceclDiceLoss` from [clDice - a Novel Topology-Preserving Loss Function for Tubular Structure Segmentation](https://openaccess.thecvf.com/content/CVPR2021/papers/Shit_clDice_-_A_Novel_Topology-Preserving_Loss_Function_for_Tubular_Structure_CVPR_2021_paper.pdf) ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
Hi, first author of clDice here. Thank you for bringing clDice to Monai. We checked the implementation and it is correct. What are the steps to make it part of the main release? |
thanks for confirming @jocpae, the module is available in monai 1.3.0 -- |
Great, thank you! I do not find it in the docs https://docs.monai.io/en/stable/losses.html yet. Should we prepare something? |
Thanks for letting me know this great news.
|
We would also like to add clDice as a metric to Monai we would do a PR soon? |
Hi @jocpae, we have a MONAI/monai/metrics/loss_metric.py Line 26 in e801540
|
Is your feature request related to a problem? Please describe.
clDice - a Novel Topology-Preserving Loss Function for Tubular Structure Segmentation
The abstract of this paper:⬇️
Describe the solution you'd like
Official code repo
Please integrate the code in Monai project, that will help lots of researchers who working on vessels, neurons, tree or tabular structure. This official code repo has already implemented 2D and 3D version clDice loss, it will be easy to merge to current MONAI project. Thank you.
The text was updated successfully, but these errors were encountered: