Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clDice loss #6763

Merged
merged 6 commits into from
Jul 25, 2023
Merged

feat: add clDice loss #6763

merged 6 commits into from
Jul 25, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented Jul 24, 2023 •
edited
Loading

Fixes #5938

Description

This PR aims to add the SoftclDiceLoss and the SoftDiceclDiceLoss from clDice - a Novel Topology-Preserving Loss Function for Tubular Structure Segmentation

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@SauravMaheshkar
feat: add clDice loss
4595dbd 
Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
@SauravMaheshkar
feat: add clDice imports to losses/__init__.py
aa7200c 
Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
@SauravMaheshkar
fix: add type hints
aadce2a 
Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
@SauravMaheshkar
feat: add tests for clDice
4dd80a4 
Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
@SauravMaheshkar
style: lint clDice tests
a2dab60 
Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
@SauravMaheshkar
fix: type hint
2303b30 
Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
@wyli
Copy link
Contributor

wyli commented Jul 25, 2023

/build

wyli
wyli approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli merged commit 2800a76 into Project-MONAI:dev Jul 25, 2023
25 of 30 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/cldice-loss branch July 25, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request : please add cldice loss
2 participants
@SauravMaheshkar @wyli