Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm -rf /opt/hostedtoolcache may change the python version actually used to run CI tests #7416

Closed
yiheng-wang-nv opened this issue Jan 25, 2024 · 0 comments · Fixed by #7424
Closed

rm -rf /opt/hostedtoolcache may change the python version actually used to run CI tests #7416

yiheng-wang-nv opened this issue Jan 25, 2024 · 0 comments · Fixed by #7424
Labels
bug Something isn't working

Comments

@yiheng-wang-nv
Copy link
Contributor

Describe the bug
When I run some tests on github action in model zoo repo, I found that the following line in the action yml file will remove the installed python version:

rm -rf /opt/hostedtoolcache

It may lead to the system's default python version will be used to run the tests.

@KumoLiu and I simply check MONAI repo, and found that at least the deploy action is impacted. In the corresponding yml file:

MONAI/.github/workflows/setupapp.yml

Line 103 in 6c9e49e

rm -rf /opt/hostedtoolcache

rm -rf /opt/hostedtoolcache is used after python env is set.

If we look at the latest deploy action job, we can see that the python3.9 test actually uses python 3.10 which is not expected.

https://github.com/Project-MONAI/MONAI/actions/runs/7648726812/job/20842001933#step:7:411

Hi @wyli @KumoLiu , I think we should think about how to install the expected python version back before running tests if need rm -rf /opt/hostedtoolcache
@yiheng-wang-nv yiheng-wang-nv mentioned this issue Jan 25, 2024
Closed
@KumoLiu KumoLiu added the bug Something isn't working label Jan 26, 2024
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Jan 30, 2024
@KumoLiu
fix Project-MONAI#7416
011edea 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu mentioned this issue Jan 30, 2024
Merged
7 tasks
KumoLiu added a commit that referenced this issue Feb 1, 2024
@KumoLiu
update rm -rf /opt/hostedtoolcache avoid change the python version (#…
cd36c1c 
…7424)

Fixes #7416

### Description

update `rm -rf /opt/hostedtoolcache` avoid change the python version

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this issue Mar 25, 2024
@KumoLiu @juampatronics
update rm -rf /opt/hostedtoolcache avoid change the python version (P…
f8bfc7c 
…roject-MONAI#7424)

Fixes Project-MONAI#7416

### Description

update `rm -rf /opt/hostedtoolcache` avoid change the python version

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
@KumoLiu @Yu0610
update rm -rf /opt/hostedtoolcache avoid change the python version (P…
37597d4 
…roject-MONAI#7424)

Fixes Project-MONAI#7416

### Description

update `rm -rf /opt/hostedtoolcache` avoid change the python version

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update rm -rf /opt/hostedtoolcache avoid change the python version KumoLiu/MONAI
2 participants
@KumoLiu @yiheng-wang-nv