Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rm -rf /opt/hostedtoolcache avoid change the python version #7424

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jan 30, 2024

Fixes #7416

Description

update rm -rf /opt/hostedtoolcache avoid change the python version

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 30, 2024

/build

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@ericspod
Copy link
Member

Why is this directory being deleted in the original? I feel it would be helpful to add a comment at the first instance of this pattern explaining the rationale so if we come back to it like we're doing now we have a better idea of what's going on.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 30, 2024

Why is this directory being deleted in the original? I feel it would be helpful to add a comment at the first instance of this pattern explaining the rationale so if we come back to it like we're doing now we have a better idea of what's going on.

Hi Eric, the original reason is the resource issue from github action. #7030

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 31, 2024

/build

1 similar comment
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 31, 2024

/build

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 1, 2024

Hi @ericspod, @yiheng-wang-nv, could you please help review it again, thanks.

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KumoLiu KumoLiu merged commit cd36c1c into Project-MONAI:dev Feb 1, 2024
28 checks passed
@KumoLiu KumoLiu deleted the rm-cache branch February 1, 2024 11:47
juampatronics pushed a commit to juampatronics/MONAI that referenced this pull request Mar 25, 2024
…roject-MONAI#7424)

Fixes Project-MONAI#7416

### Description

update `rm -rf /opt/hostedtoolcache` avoid change the python version

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this pull request Apr 11, 2024
…roject-MONAI#7424)

Fixes Project-MONAI#7416

### Description

update `rm -rf /opt/hostedtoolcache` avoid change the python version

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rm -rf /opt/hostedtoolcache may change the python version actually used to run CI tests
3 participants