Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3624 Add kwargs to torch APIs of utilities #3631

Merged
merged 7 commits into from
Jan 10, 2022
Merged

3624 Add kwargs to torch APIs of utilities #3631

merged 7 commits into from
Jan 10, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jan 10, 2022

Fixes #3624 .

Description

This PR added the kwargs to torch utilities as contiguous, and also added doc-strings.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 10, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 10, 2022

/build

@Nic-Ma Nic-Ma requested review from rijobro, wyli and ericspod January 10, 2022 15:43
@wyli wyli mentioned this pull request Jan 10, 2022
Merged
7 tasks
@Nic-Ma
[DLMED] update according to comments
433f102 
Signed-off-by: Nic Ma <nma@nvidia.com>
wyli
wyli approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Jan 10, 2022

/build

@wyli wyli enabled auto-merge (squash) January 10, 2022 17:41
@wyli wyli merged commit 2fef7ff into Project-MONAI:dev Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add kwargs to pytorch_numpy_unification
2 participants
@Nic-Ma @wyli