Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pytorch version #6228

Merged
merged 6 commits into from
Mar 23, 2023
Merged

upgrade pytorch version #6228

merged 6 commits into from
Mar 23, 2023

Conversation

YanxuanLiu
Copy link
Collaborator

Fixes #6221

Description

Upgrade Pytorch version to 23.02

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@YanxuanLiu YanxuanLiu requested review from wyli and Nic-Ma March 23, 2023 01:57
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@wyli Could you please help double confirm it?

Thanks in advance.

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@YanxuanLiu
Copy link
Collaborator Author

/build

@wyli
Copy link
Contributor

wyli commented Mar 23, 2023

Hi @YanxuanLiu there are testing issues, please see the blossom logs.

@YanxuanLiu
Copy link
Collaborator Author

/build

@wyli wyli force-pushed the upgrade_pytorch branch from 8b1a678 to 8545049 Compare March 23, 2023 08:30
wyli added 3 commits March 23, 2023 13:00
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Mar 23, 2023

/build

@wyli wyli enabled auto-merge (squash) March 23, 2023 13:03
@wyli wyli merged commit 1cd0d7b into Project-MONAI:dev Mar 23, 2023
jak0bw pushed a commit to jak0bw/MONAI that referenced this pull request Mar 28, 2023
Fixes Project-MONAI#6221 

### Description

Upgrade Pytorch version to 23.02

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
jak0bw pushed a commit to jak0bw/MONAI that referenced this pull request Mar 28, 2023
Fixes Project-MONAI#6221 

### Description

Upgrade Pytorch version to 23.02

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update base PyTorch docker to 23.02
3 participants