Skip to content

Commit

Permalink
upgrade pytorch version (Project-MONAI#6228)
Browse files Browse the repository at this point in the history
Fixes Project-MONAI#6221 

### Description

Upgrade Pytorch version to 23.02

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
  • Loading branch information
2 people authored and jak0bw committed Mar 28, 2023
1 parent ebbeff9 commit bb4ba19
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 8 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
base: "nvcr.io/nvidia/pytorch:21.06-py3" # CUDA 11.3
- environment: PTLATEST+CUDA118
pytorch: "-U torch torchvision --extra-index-url https://download.pytorch.org/whl/cu118"
base: "nvcr.io/nvidia/pytorch:22.12-py3" # CUDA 11.8
base: "nvcr.io/nvidia/pytorch:23.02-py3" # CUDA 11.8
container:
image: ${{ matrix.base }}
options: "--gpus all"
Expand All @@ -39,7 +39,6 @@ jobs:
- uses: actions/checkout@v3
- name: apt install
run: |
# FIXME: workaround for https://github.com/Project-MONAI/MONAI/issues/4200
apt-get update
apt-get install -y wget
- name: Install the dependencies
Expand Down Expand Up @@ -77,7 +76,7 @@ jobs:
if: github.repository == 'Project-MONAI/MONAI'
strategy:
matrix:
container: ["pytorch:22.09", "pytorch:22.11", "pytorch:22.12"]
container: ["pytorch:22.09", "pytorch:22.11", "pytorch:23.02"]
container:
image: nvcr.io/nvidia/${{ matrix.container }}-py3 # testing with the latest pytorch base image
options: "--gpus all"
Expand Down Expand Up @@ -122,7 +121,7 @@ jobs:
if: github.repository == 'Project-MONAI/MONAI'
strategy:
matrix:
container: ["pytorch:22.09", "pytorch:22.11", "pytorch:22.12"]
container: ["pytorch:22.09", "pytorch:22.11", "pytorch:23.02"]
container:
image: nvcr.io/nvidia/${{ matrix.container }}-py3 # testing with the latest pytorch base image
options: "--gpus all"
Expand Down Expand Up @@ -222,7 +221,7 @@ jobs:
if: github.repository == 'Project-MONAI/MONAI'
needs: cron-gpu # so that monai itself is verified first
container:
image: nvcr.io/nvidia/pytorch:22.12-py3 # testing with the latest pytorch base image
image: nvcr.io/nvidia/pytorch:23.02-py3 # testing with the latest pytorch base image
options: "--gpus all --ipc=host"
runs-on: [self-hosted, linux, x64, integration]
steps:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/pythonapp-gpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ jobs:
- environment: PT113+CUDA116
pytorch: "torch==1.13.1 torchvision==0.14.1"
base: "nvcr.io/nvidia/cuda:11.6.1-devel-ubuntu18.04"
- environment: PT114+CUDA120DOCKER
# 23.02: 1.14.0a0+44dac51
pytorch: "-h" # we explicitly set pytorch to -h to avoid pip install error
base: "nvcr.io/nvidia/pytorch:23.02-py3"
container:
image: ${{ matrix.base }}
options: --gpus all --env NVIDIA_DISABLE_REQUIRE=true # workaround for unsatisfied condition: cuda>=11.6
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ sphinx:

# Optionally set the version of Python and requirements required to build your docs
python:
version: 3.8
version: 3
install:
- requirements: docs/requirements.txt
# system_packages: true
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

# To build with a different base image
# please run `docker build` using the `--build-arg PYTORCH_IMAGE=...` flag.
ARG PYTORCH_IMAGE=nvcr.io/nvidia/pytorch:22.12-py3
ARG PYTORCH_IMAGE=nvcr.io/nvidia/pytorch:23.02-py3
FROM ${PYTORCH_IMAGE}

LABEL maintainer="monai.contact@gmail.com"
Expand Down
2 changes: 1 addition & 1 deletion tests/test_dynunet.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def test_script(self):

# @skip_if_no_cuda
# @skip_if_windows
@unittest.skip("temporary skip for 22.12")
@unittest.skip("temporary skip for 22.12/23.02")
class TestDynUNetWithInstanceNorm3dNVFuser(unittest.TestCase):
@parameterized.expand([TEST_CASE_DYNUNET_3D[0]])
def test_consistency(self, input_param, input_shape, _):
Expand Down

0 comments on commit bb4ba19

Please sign in to comment.