Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

909 Add NumpyReader for IO factory #964

Merged
merged 7 commits into from
Aug 28, 2020
Merged

909 Add NumpyReader for IO factory #964

merged 7 commits into from
Aug 28, 2020

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Aug 27, 2020 •
edited
Loading

Part of #909

Description

This PR implemented NumpyReader which is part of the IO factory task.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 28, 2020

/black

@Nic-Ma Nic-Ma marked this pull request as ready for review August 28, 2020 03:19
@Nic-Ma Nic-Ma changed the title [WIP] 909 Add NumpyReader 909 Add NumpyReader for IO factory Aug 28, 2020
@ericspod ericspod merged commit 35ef648 into Project-MONAI:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

@wyli wyli Awaiting requested review from wyli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nic-Ma @ericspod @monai-bot