fix(DICOMDataLoaderOperator): Fail gracefully if invalid files are in the input directory #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the input directory Signed-off-by: Erik <erik.ziegler@radicalimaging.com>
Contributor
Author
|
OK so it looks like I can close this then! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DICOM Data Loader Operator has a small issue where if there is any non-DICOM file in the folder, the reader will fail entirely.
I encountered this on MacOS because it creates .DS_Store files in each directory automatically.
This just adds a bit of error handling to log out which files did not read correctly and continue processing those that did.
I'm not sure I've added the logger properly though, because I couldn't get it to actually log anything (though it matches how it's used in other files). Using print() worked fine though.
Thanks!