Relaxed the restriction on non-DCM files, and raise error based on settings #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttings Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
mocsharp
approved these changes
Mar 1, 2022
jlvahldiek
pushed a commit
to jlvahldiek/monai-deploy-app-sdk
that referenced
this pull request
Mar 31, 2022
…ttings (Project-MONAI#273) Signed-off-by: mmelqin <mingmelvinq@nvidia.com> Signed-off-by: Janis <janis@vahldiek.info>
MMelQin
added a commit
that referenced
this pull request
Apr 1, 2022
* Relaxed the restriction on non-DCM files, and raise error based on settings (#273) Signed-off-by: mmelqin <mingmelvinq@nvidia.com> Signed-off-by: Janis <janis@vahldiek.info> * fix pixel spacing fix pixel spacing if [0x0028, 0x0030] is not available Signed-off-by: Janis <janis@vahldiek.info> * fix pixel spacing fix pixel spacing if [0x0028, 0x0030] is not available Signed-off-by: Janis <janis@vahldiek.info> * Revert "fix pixel spacing" This reverts commit a4073db. Signed-off-by: Janis <janis@vahldiek.info> * add default value add default value of "None" to meta_dict["original_affine"] Signed-off-by: Janis Vahldiek <janis@vahldiek.info> Signed-off-by: Janis <janis@vahldiek.info> * add KeyError Signed-off-by: Janis Vahldiek <janis@vahldiek.info> Signed-off-by: Janis <janis@vahldiek.info> * make black happy Signed-off-by: Janis <janis@vahldiek.info> * Mqin/fix doc typos (#274) * Fixed typo in inline comments. Signed-off-by: mmelqin <mingmelvinq@nvidia.com> * Checked and fixed typo for all Operators Signed-off-by: mmelqin <mingmelvinq@nvidia.com> * Added notes in the Jupyter notebooks Signed-off-by: mmelqin <mingmelvinq@nvidia.com> Signed-off-by: Janis <janis@vahldiek.info> * Revert "make black happy" This reverts commit 62996dc. Signed-off-by: Janis <janis@vahldiek.info> * make black happy Signed-off-by: Janis <janis@vahldiek.info> * fix pixel spacing fix pixel spacing if [0x0028, 0x0030] is not available Signed-off-by: Janis <janis@vahldiek.info> * fix pixel spacing fix pixel spacing if [0x0028, 0x0030] is not available Signed-off-by: Janis <janis@vahldiek.info> * Revert "fix pixel spacing" This reverts commit a4073db. Signed-off-by: Janis <janis@vahldiek.info> * add KeyError Signed-off-by: Janis Vahldiek <janis@vahldiek.info> * Revert "make black happy" This reverts commit 62996dc. Signed-off-by: Janis <janis@vahldiek.info> * make black happy Signed-off-by: Janis <janis@vahldiek.info> Co-authored-by: Ming M Qin <38891913+MMelQin@users.noreply.github.com>
Merged
MMelQin
deleted the
mingq/DICOMDataLoaderOperator_to_ignore_nonDCM_files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been found that this loader is overly restrictive in that it expects a folder containing only valid DCIOM part 10 files.
So, this PR is to
Signed-off-by: mmelqin mingmelvinq@nvidia.com