Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 24, 2022

Description

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@mocsharp mocsharp added this to the 0.2.11 milestone Nov 24, 2022
@mocsharp mocsharp added the enhancement New feature or request label Nov 24, 2022
@mocsharp mocsharp self-assigned this Nov 24, 2022
gh-25 Change APIs for Verify..

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #125 (0514c6f) into develop (0d792f2) will increase coverage by 28.50326%.
The diff coverage is 85.11327%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             develop        #125          +/-   ##
====================================================
+ Coverage   51.92127%   80.42453%   +28.50326%     
====================================================
  Files             27          31           +4     
  Lines           1067        1272         +205     
  Branches          67          72           +5     
====================================================
+ Hits             554        1023         +469     
+ Misses           500         213         -287     
- Partials          13          36          +23     
Flag Coverage Δ
unittests 80.42453% <85.11327%> (+28.50326%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/MinIO/Tests/Unit/MinIoAdminHealthCheckTest.cs 100.00000% <ø> (ø)
...c/Plugins/MinIO/Tests/Unit/MinIoHealthCheckTest.cs 100.00000% <ø> (ø)
src/Plugins/MinIO/Tests/Unit/MinIoStartupTest.cs 100.00000% <ø> (ø)
...gins/MinIO/Tests/Unit/MinioPolicyExtensionsTest.cs 100.00000% <ø> (ø)
...lugins/MinIO/Tests/Unit/ServiceRegistrationTest.cs 100.00000% <ø> (ø)
src/Storage/IServiceCollectionExtension.cs 81.81818% <ø> (ø)
...Storage/Tests/IServiceCollectionExtensionsTests.cs 82.60870% <0.00000%> (ø)
src/Plugins/MinIO/MinIoStorageService.cs 63.33333% <56.36364%> (+63.33332%) ⬆️
...ins/MinIO/Tests/Integration/MinIoStorageFixture.cs 67.44186% <67.44186%> (ø)
...MinIO/Tests/Integration/StorageAdminServiceTest.cs 91.11111% <91.11111%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6999f5f...0514c6f. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp requested review from lillie-dae and neildsouth and removed request for lillie-dae November 28, 2022 21:28
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 2889b5e into develop Nov 29, 2022
@mocsharp mocsharp deleted the gh-20 branch November 29, 2022 14:14
mocsharp added a commit that referenced this pull request Nov 30, 2022
+semver: patch

* Sync Main branch (#115)

* Integration test for MinIO & API update for VerifyObject(s)ExistsAsync (#125)

* Update packages (#133)



Signed-off-by: Victor Chang <vicchang@nvidia.com>

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.11 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants