Skip to content

Update packages #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update packages #133

merged 1 commit into from
Nov 30, 2022

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 30, 2022

Signed-off-by: Victor Chang vicchang@nvidia.com

Description

Fixes # .

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@mocsharp mocsharp added the dependencies Pull requests that update a dependency file label Nov 30, 2022
@mocsharp mocsharp added this to the 0.2.11 milestone Nov 30, 2022
@mocsharp mocsharp requested a review from neildsouth November 30, 2022 18:12
@codecov
Copy link

codecov bot commented Nov 30, 2022 •
edited
Loading

Codecov Report

Merging #133 (a188e8b) into develop (2889b5e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop        #133   +/-   ##
=============================================
  Coverage   80.42453%   80.42453%           
=============================================
  Files             31          31           
  Lines           1272        1272           
  Branches          72          72           
=============================================
  Hits            1023        1023           
  Misses           213         213           
  Partials          36          36
Flag Coverage Δ
unittests 80.42453% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2889b5e...a188e8b. Read the comment docs.

@mocsharp
Update packages
a188e8b 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/update-packages branch from a11ecb8 to a188e8b Compare November 30, 2022 18:46
dbericat
dbericat approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@dbericat dbericat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocsharp mocsharp merged commit 5265b5d into develop Nov 30, 2022
mocsharp added a commit that referenced this pull request Nov 30, 2022
@mocsharp
Release/0.2.11 (#134)
1fc8b15 
+semver: patch

* Sync Main branch (#115)

* Integration test for MinIO & API update for VerifyObject(s)ExistsAsync (#125)

* Update packages (#133)



Signed-off-by: Victor Chang <vicchang@nvidia.com>

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the enhancement New feature or request label Nov 30, 2022
@github-actions
Copy link

github-actions bot commented Nov 30, 2022

🎉 This issue has been resolved in version 0.2.11 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbericat dbericat dbericat approved these changes

@neildsouth neildsouth Awaiting requested review from neildsouth

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Milestone

0.2.11

Development

Successfully merging this pull request may close these issues.

3 participants

@mocsharp @dbericat