Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing instruction at a ramp bifurcation #4895

Closed
oxidase opened this issue Feb 19, 2018 · 3 comments
Closed

Missing instruction at a ramp bifurcation #4895

oxidase opened this issue Feb 19, 2018 · 3 comments
Assignees

Comments

@oxidase
Copy link
Contributor

oxidase commented Feb 19, 2018

At ramp bifurcations OSRM suppresses obvious instructions
http://map.project-osrm.org/?z=18&center=33.645919%2C-84.444394&loc=33.645961%2C-84.443981&loc=33.646068%2C-84.445086&hl=en&alt=0
screenshot from 2018-02-19 10-02-21

Valhalla does not suppress turn instructions in similar case and produces for the above route Keep right to take I 85 South toward I 285/Montgomery. instruction due to condition maneuver.ramp() && prev_edge->IsRampUse()

In order to synchronize guidance instructions OSRM should handle a case of ramp bifurcations as non-obvious. The current OSRM ramp bifurcations implementation is captured by the feature tests:

/cc @srividyacb @dgearhart

@dgearhart
Copy link
Contributor

@oxidase Are you saying the Kreuz Oranienburg test case will be fixed?
screenshot from 2018-02-19 10-29-33
so both will now say Keep left at the fork...

@oxidase
Copy link
Contributor Author

oxidase commented Feb 19, 2018

@dgearhart yes, the third instruction will be Keep left at the fork towards A 111: Berlin

@dgearhart
Copy link
Contributor

@oxidase excellent! Thanks

datendelphin added a commit to fossgis-routing-server/osrm-backend that referenced this issue Jun 10, 2018
  - Changes from 5.15.2:
    - Guidance
      - ADDED Project-OSRM#4676: Support for maneuver override relation, allowing data-driven overrides for turn-by-turn instructions [Project-OSRM#4676](Project-OSRM#4676)
      - CHANGED Project-OSRM#4830: Announce reference change if names are empty
      - CHANGED Project-OSRM#4835: MAXIMAL_ALLOWED_SEPARATION_WIDTH increased to 12 meters
      - CHANGED Project-OSRM#4842: Lower priority links from a motorway now are used as motorway links [Project-OSRM#4842](Project-OSRM#4842)
      - CHANGED Project-OSRM#4895: Use ramp bifurcations as fork intersections [Project-OSRM#4895](Project-OSRM#4895)
      - CHANGED Project-OSRM#4893: Handle motorway forks with links as normal motorway intersections[Project-OSRM#4893](Project-OSRM#4893)
      - FIXED Project-OSRM#4905: Check required tags of `maneuver` relations [Project-OSRM#4905](Project-OSRM#4905)
    - Profile:
      - FIXED: `highway=service` will now be used for restricted access, `access=private` is still disabled for snapping.
      - ADDED Project-OSRM#4775: Exposes more information to the turn function, now being able to set turn weights with highway and access information of the turn as well as other roads at the intersection [Project-OSRM#4775](Project-OSRM#4775)
      - FIXED Project-OSRM#4763: Add support for non-numerical units in car profile for maxheight [Project-OSRM#4763](Project-OSRM#4763)
      - ADDED Project-OSRM#4872: Handling of `barrier=height_restrictor` nodes [Project-OSRM#4872](Project-OSRM#4872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants