Handle motorway forks with links as normal motorway intersections #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxidase
changed the title
oxidase
force-pushed
the
guidance/highway-with-a-link
branch
from
fe5d39c
to
802bdb1
Compare
oxidase
force-pushed
the
guidance/highway-with-a-link
branch
from
802bdb1
to
3926641
Compare
|
Worth noting as well that the osrm map tile at that location needs to be updated.. https://www.openstreetmap.org/directions?engine=osrm_car&route=53.30787%2C-2.37205%3B53.46230%2C-2.24521#map=11/53.3846/-2.3317
|
|
@jguthrie100 👋 I have found the issue while looking at #4892. The data fix for #4892 will be visible after the OSM change will propagate in the data pipeline. But correct instructions at the intersection will be visible after the next OSRM release. |
|
Maybe, but the error is in the same place when using Graphhopper too, which makes me think it's probably something to do with the underlying data (which I've hopefully now fixed in OSM)
|
|
It looks like this PR is out of sync with master rn though. Rebase and merge? 😄 |
passing some ramps or mering onto another motorway
oxidase
force-pushed
the
guidance/highway-with-a-link
branch
from
3926641
to
bf05ee0
Compare
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Jun 10, 2018
- Changes from 5.15.2:
- Guidance
- ADDED Project-OSRM#4676: Support for maneuver override relation, allowing data-driven overrides for turn-by-turn instructions [Project-OSRM#4676](Project-OSRM#4676)
- CHANGED Project-OSRM#4830: Announce reference change if names are empty
- CHANGED Project-OSRM#4835: MAXIMAL_ALLOWED_SEPARATION_WIDTH increased to 12 meters
- CHANGED Project-OSRM#4842: Lower priority links from a motorway now are used as motorway links [Project-OSRM#4842](Project-OSRM#4842)
- CHANGED Project-OSRM#4895: Use ramp bifurcations as fork intersections [Project-OSRM#4895](Project-OSRM#4895)
- CHANGED Project-OSRM#4893: Handle motorway forks with links as normal motorway intersections[Project-OSRM#4893](Project-OSRM#4893)
- FIXED Project-OSRM#4905: Check required tags of `maneuver` relations [Project-OSRM#4905](Project-OSRM#4905)
- Profile:
- FIXED: `highway=service` will now be used for restricted access, `access=private` is still disabled for snapping.
- ADDED Project-OSRM#4775: Exposes more information to the turn function, now being able to set turn weights with highway and access information of the turn as well as other roads at the intersection [Project-OSRM#4775](Project-OSRM#4775)
- FIXED Project-OSRM#4763: Add support for non-numerical units in car profile for maxheight [Project-OSRM#4763](Project-OSRM#4763)
- ADDED Project-OSRM#4872: Handling of `barrier=height_restrictor` nodes [Project-OSRM#4872](Project-OSRM#4872)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If a motorway fork intersection has links the motorway handler can assign incorrect
Leftmodifierhttp://map.project-osrm.org/?z=18¢er=53.461582%2C-2.244827&loc=53.461383%2C-2.245116&loc=53.462187%2C-2.245100&hl=en&alt=0
PR changes handling of motorway intersections to a case of a normal motorway passing some ramps if
exiting_motorwaysis not equal tovalid_exits.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?