Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Turn Function #2912

Closed
wants to merge 8 commits into from
Closed

Improve Turn Function #2912

wants to merge 8 commits into from

Conversation

MoKob
Copy link

@MoKob MoKob commented Sep 14, 2016

Issue

Testing PR, looking at penalising turns through traffic. This essentially adds an additional penalty to left turns if they are going through opposing traffic.

       d
       |
a ---- b ---- c

Would add an additional penalty for turning left a-b-d but not for d-b-c.

Tasklist

  • add regression / cucumber cases (see docs/testing.md)
  • review
  • adjust for for comments

@MoKob
Copy link
Author

MoKob commented Sep 26, 2016

Related: #2822

@MoKob MoKob changed the title penalise turning through opposite traffic Improve Turn Function Oct 5, 2016
@MoKob MoKob force-pushed the profile/cross_traffic_penalty branch from 51caa75 to 6fa7ffd Compare October 12, 2016 11:29
@TheMarex
Copy link
Member

Just to put this on your radar: I had to switch to a more structured approach in #2399 that passes an object to the turn function similar to the way_function and node_function https://github.com/Project-OSRM/osrm-backend/pull/2399/files#diff-e262c8e753c419376683e5d8b10ba793R13 Depending on when you plan to implement this you could just piggy back on this and add the additional parameters to that struct.

@MoKob MoKob force-pushed the profile/cross_traffic_penalty branch from 6fe7d62 to ed4839b Compare October 13, 2016 09:44
@MoKob
Copy link
Author

MoKob commented Apr 18, 2017

Outdated. In general I'd still think we could improve the turn function by considering many of the tested parameters.
Especially if you are crossing through oncoming traffic would be nice to have (but also depends on traffic light settings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants