Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatbuffers support added #5513

Merged
merged 32 commits into from
Aug 29, 2019
Merged

Flatbuffers support added #5513

merged 32 commits into from
Aug 29, 2019

Conversation

akashihi
Copy link
Contributor

Closes # 5512

@akashihi akashihi force-pushed the flatbuffers branch 7 times, most recently from 3ba6170 to 7d4fffb Compare August 16, 2019 09:26
gardster
gardster reviewed Aug 19, 2019
View reviewed changes
docs/http.md Outdated Show resolved Hide resolved
@akashihi akashihi force-pushed the flatbuffers branch 2 times, most recently from 6496b1a to 050e673 Compare August 23, 2019 11:01
Denis Chaplygin added 20 commits August 26, 2019 11:08
Added output format parser to the Route service.
59ca784 
It is possible now to choose between json and flatbuffers (not yet implemented) output format.
Only route service is supported atm.
Added output format parser to the other services.
59a83bd 
Same as for Route service, you can now specify either json or flatbuffers
as output format for the other services (except Tile service, where it
makes no sense).
Flatbuffers library added to the list of third party libraries.
3f34c8d
Added flatbuffers schema.
f6f86b2
Passed ResultT down to engine plugins, so now they can form replies i…
75aadb0 
…n different formats.
Added flatbuffer support to the server request handler.
56406e8
Added flatbuffers support to the PluginBase::Error
7ddda10 
This changes BREAKS osrm.
Added full flatbuffers support to the Table service
ea11112
Removed ineffectivness in the serialization schema. Positions are
acd3e81 
structs now and distance/duration matrices are just arrays.
Added flatbuffers output support to the 'Nearest' service.
9d7a744
Added flatbuffers output support to the 'Route' service.
affa8a4
Optimizing FB schema:
13287d9 
* Replaced Response union with nullable fields
* "Ok" code replaced with a boolean and a separate structure for a error code and message.
* Inlined geometry, thus removing one layer of indirection.
Added flatbuffers output support to the 'Trip' service.
b7e9e5f
Added flatbuffers output support to the 'Match' service
90191c9
Added flatbuffers compatibility to the Node
e26a5cc
Unit tests are compatible with new plugin API.
a44a75b
Inlined routes and waypoints, as all services are using at least one …
533f1ff 
…of those object, so there is no need for another one level of indirection.
Generalized flatbuffers response generation in 'Route','Trip','Match'…
306c047 
… services.
Set flatbuffers root type and removed unneded array for rows/cols
889c825
Slightly changed the serialization order.
73f544d
Denis Chaplygin added 11 commits August 26, 2019 11:08
Added short flatbuffers introduction.
5888894
Flatbuffers now uses floats instead of double. We do not use that pre…
2a1593f 
…cision anyway and it make output much smaller.
base_result is a part of public API now, so it needs to be installed
1a259cc
Vendored flatbuffers headers should be installed with the libosrm
a196e67
Library example now shows, how to use different output formats.
ff46e98
Updated changelog entry
a9c187c
Fixed nested offsets inside of the flatbuffers structure
97270ae
Added tests for Nearest/Table/Route flatbuffers serialization.
ce71e08
Added setting 'data_version' to all flatbuffers response functions.
80e1abb
Replaced 'in' and 'out' at the flatbuffers 'instersection' object
b8182dd 
with 'in_bearing' and 'out_bearing' to get flatbuffers schema javascript friendly.

Added a cucumber test for flatbuffers support.
Fixed typo in flatbuffers: longitute -> longitude.
0be87c7
gardster
gardster approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@gardster gardster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It is better to cover all plugins and cases with flatbuffers protocol checks to be sure, that both protocols supports all features. But I think that we can merge this PR as a start as multi protocol support and then improve test coverage.

@gardster gardster merged commit f1a4b70 into Project-OSRM:master Aug 29, 2019
@gardster
Copy link
Contributor

Thank you for the contribution!

@akashihi akashihi deleted the flatbuffers branch August 30, 2019 09:27
@gardster gardster mentioned this pull request Sep 12, 2019
Closed
datendelphin added a commit to fossgis-routing-server/osrm-backend that referenced this pull request Nov 19, 2020
@datendelphin
Merge tag 'v5.23.0'
a823897 
  - Changes from 5.22.0
    - Build:
      - FIXED: pessimistic calls to std::move [Project-OSRM#5560](Project-OSRM#5561)
    - Features:
      - ADDED: new API parameter - `snapping=any|default` to allow snapping to previously unsnappable edges [Project-OSRM#5361](Project-OSRM#5361)
      - ADDED: keepalive support to the osrm-routed HTTP server [Project-OSRM#5518](Project-OSRM#5518)
      - ADDED: flatbuffers output format support [Project-OSRM#5513](Project-OSRM#5513)
      - ADDED: Global 'skip_waypoints' option [Project-OSRM#5556](Project-OSRM#5556)
      - FIXED: Install the libosrm_guidance library correctly [Project-OSRM#5604](Project-OSRM#5604)
      - FIXED: Http Handler can now deal witch optional whitespace between header-key and -value [Project-OSRM#5606](Project-OSRM#5606)
    - Routing:
      - CHANGED: allow routing past `barrier=arch` [Project-OSRM#5352](Project-OSRM#5352)
      - CHANGED: default car weight was reduced to 2000 kg. [Project-OSRM#5371](Project-OSRM#5371)
      - CHANGED: default car height was reduced to 2 meters. [Project-OSRM#5389](Project-OSRM#5389)
      - FIXED: treat `bicycle=use_sidepath` as no access on the tagged way. [Project-OSRM#5622](Project-OSRM#5622)
      - FIXED: fix table result when source and destination on same one-way segment. [Project-OSRM#5828](Project-OSRM#5828)
      - FIXED: fix occasional segfault when swapping data with osrm-datastore and using `exclude=` [Project-OSRM#5844](Project-OSRM#5844)
      - FIXED: fix crash in MLD alternative search if source or target are invalid [Project-OSRM#5851](Project-OSRM#5851)
    - Misc:
      - CHANGED: Reduce memory usage for raster source handling. [Project-OSRM#5572](Project-OSRM#5572)
      - CHANGED: Add cmake option `ENABLE_DEBUG_LOGGING` to control whether output debug logging. [Project-OSRM#3427](Project-OSRM#3427)
      - CHANGED: updated extent of Hong Kong as left hand drive country. [Project-OSRM#5535](Project-OSRM#5535)
      - FIXED: corrected error message when failing to snap input coordinates [Project-OSRM#5846](Project-OSRM#5846)
    - Infrastructure
      - REMOVED: STXXL support removed as STXXL became abandonware. [Project-OSRM#5760](Project-OSRM#5760)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardster gardster gardster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akashihi @gardster