Use apt-get to install Clang on CI #6345

SiarheiFedartsou · 2022-08-28T09:02:03Z

Issue

related to #6266

Also will allow us to bump Clang version in the future.

Tasklist

CHANGELOG.md entry (How to write a changelog entry)
update relevant Wiki pages
add tests (see testing documentation)
review
adjust for comments
cherry pick to release branch

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

SiarheiFedartsou · 2022-08-28T09:48:45Z

.github/workflows/osrm-backend.yml

-          ${MASON} install clang++ ${CLANG_VERSION}
-          echo "$(${MASON} prefix clang++ ${CLANG_VERSION})/bin" >> $GITHUB_PATH
+          sudo apt-get update -y && sudo apt-get install "clang++-${CLANG_VERSION}"
+          if [[ "${CLANG_VERSION}" = "6" ]]; then


Clang 6 is installed as /usr/bin/clang++-6.0 and Clang 11 as /usr/bin/clang++-11, so had to do this.
It is a bit ugly, but couldn't find better way.

Is this the same package as https://packages.ubuntu.com/focal/clang-6.0?

I think so.

Is it possible to set CCOMPILER/CXXCOMPILER to e.g. clang-6.0/clang++6.0 and then just install all compilers at L543? Or is there a step that's requiring the symlink?

It seems it works, a way more elegant solution, thanks 👍

SiarheiFedartsou · 2022-08-28T09:50:40Z

.github/workflows/osrm-backend.yml

@@ -556,6 +561,12 @@ jobs:
        tar zxvf onetbb.tgz
        sudo cp -a oneapi-tbb-${TBB_VERSION}/lib/. /usr/local/lib/
        sudo cp -a oneapi-tbb-${TBB_VERSION}/include/. /usr/local/include/
+    - name: Check clang version


Kind of self-check that actual clang version is the same as expected.

SiarheiFedartsou · 2022-08-28T09:51:56Z

.github/workflows/osrm-backend.yml

@@ -138,7 +138,7 @@ jobs:
            runs-on: ubuntu-20.04
            BUILD_TOOLS: ON
            BUILD_TYPE: Debug
-            CLANG_VERSION: 6.0.0
+            CLANG_VERSION: 6


We could just use CCOMPILER/CXXCOMPILER to use pre-installed clang, but the lowest pre-installed version is only 10: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md

SiarheiFedartsou · 2022-08-28T10:08:50Z

.github/workflows/osrm-backend.yml

@@ -157,7 +157,7 @@ jobs:
            runs-on: ubuntu-20.04
            BUILD_TOOLS: ON
            BUILD_TYPE: Release
-            CLANG_VERSION: 11.0.0
+            CLANG_VERSION: 11


Do we have any obligations to support certain old compilers btw?

Ideally for release builds we want to use a compiler that supports the minimum requirements of the oldest Node platform in our matrix. This is to avoid any ABI/stdlib incompatibilities with the host environments (example: #4567)

This is the toolchain info for Node 12: https://github.com/nodejs/node/blob/v12.x/BUILDING.md

mjjbell · 2022-08-29T21:54:15Z

.github/workflows/osrm-backend.yml

@@ -330,7 +338,8 @@ jobs:
            node: 16
            runs-on: ubuntu-20.04
            BUILD_TYPE: Release
-            CLANG_VERSION: 6.0.0


I think all references to CLANG_VERSION can be removed now?

v5.27.0 - Changes from 5.26.0 - API: - ADDED: Add Flatbuffers support to NodeJS bindings. [Project-OSRM#6338](Project-OSRM#6338) - CHANGED: Add `data_version` field to responses of all services. [Project-OSRM#5387](Project-OSRM#5387) - FIXED: Use Boost.Beast to parse HTTP request. [Project-OSRM#6294](Project-OSRM#6294) - FIXED: Fix inefficient osrm-routed connection handling [Project-OSRM#6113](https://gihub.com/Project-OSRM/osrm-backend/pull/6113) - FIXED: Fix HTTP compression precedence [Project-OSRM#6113](Project-OSRM#6113) - NodeJS: - FIXED: Support `skip_waypoints` in Node bindings [Project-OSRM#6060](Project-OSRM#6060) - Misc: - ADDED: conanbuildinfo.json for easy reading of dependencies [Project-OSRM#6388](Project-OSRM#6388) - CHANGED: Improve performance of JSON rendering. Fix undefined behaviour in JSON numbers formatting. [Project-OSRM#6380](Project-OSRM#6380) - ADDED: Add timestamps for logs. [Project-OSRM#6375](Project-OSRM#6375) - CHANGED: Improve performance of map matching via getPathDistance optimization. [Project-OSRM#6378](Project-OSRM#6378) - CHANGED: Optimize RestrictionParser performance. [Project-OSRM#6344](Project-OSRM#6344) - ADDED: Support floats for speed value in traffic updates CSV. [Project-OSRM#6327](Project-OSRM#6327) - CHANGED: Use Lua 5.4 in Docker image. [Project-OSRM#6346](Project-OSRM#6346) - CHANGED: Remove redundant nullptr check. [Project-OSRM#6326](Project-OSRM#6326) - CHANGED: missing files list is included in exception message. [Project-OSRM#5360](Project-OSRM#5360) - CHANGED: Do not use deprecated Callback::Call overload in Node bindings. [Project-OSRM#6318](Project-OSRM#6318) - FIXED: Fix distance calculation consistency. [Project-OSRM#6315](Project-OSRM#6315) - FIXED: Fix performance issue after migration to sol2 3.3.0. [Project-OSRM#6304](Project-OSRM#6304) - CHANGED: Pass osm_node_ids by reference in osrm::updater::Updater class. [Project-OSRM#6298](Project-OSRM#6298) - FIXED: Fix bug with reading Set values from Lua scripts. [Project-OSRM#6285](Project-OSRM#6285) - FIXED: Bug in bicycle profile that caused exceptions if there is a highway=bicycle in the data. [Project-OSRM#6296](Project-OSRM#6296) - FIXED: Internal refactoring of identifier types used in data facade [Project-OSRM#6044](Project-OSRM#6044) - CHANGED: Update docs to reflect recent build and dependency changes [Project-OSRM#6383](Project-OSRM#6383) - Build: - REMOVED: Get rid of Mason. [Project-OSRM#6387](Project-OSRM#6387) - CHANGED: Use clang-format from CI base image. [Project-OSRM#6391](Project-OSRM#6391) - ADDED: Build Node bindings on Windows. [Project-OSRM#6334](Project-OSRM#6334) - ADDED: Configure cross-compilation for Apple Silicon. [Project-OSRM#6360](Project-OSRM#6360) - CHANGED: Use apt-get to install Clang on CI. [Project-OSRM#6345](Project-OSRM#6345) - CHANGED: Fix TBB in case of Conan + NodeJS build. [Project-OSRM#6333](Project-OSRM#6333) - CHANGED: Migrate to modern TBB version. [Project-OSRM#6300](Project-OSRM#6300) - CHANGED: Enable performance-move-const-arg clang-tidy check. [Project-OSRM#6319](Project-OSRM#6319) - CHANGED: Use the latest node on CI. [Project-OSRM#6317](Project-OSRM#6317) - CHANGED: Migrate Windows CI to GitHub Actions. [Project-OSRM#6312](Project-OSRM#6312) - ADDED: Add smoke test for Docker image. [Project-OSRM#6313](Project-OSRM#6313) - CHANGED: Update libosmium to version 2.18.0. [Project-OSRM#6303](Project-OSRM#6303) - CHANGED: Remove EXACT from find_package if using Conan. [Project-OSRM#6299](Project-OSRM#6299) - CHANGED: Configure Undefined Behaviour Sanitizer. [Project-OSRM#6290](Project-OSRM#6290) - CHANGED: Use Conan instead of Mason to install code dependencies. [Project-OSRM#6284](Project-OSRM#6284) - CHANGED: Migrate to C++17. Update sol2 to 3.3.0. [Project-OSRM#6279](Project-OSRM#6279) - CHANGED: Update macOS CI image to macos-11. [Project-OSRM#6286](Project-OSRM#6286) - CHANGED: Enable even more clang-tidy checks. [Project-OSRM#6273](Project-OSRM#6273) - CHANGED: Configure CMake to not build flatbuffers tests and samples. [Project-OSRM#6274](Project-OSRM#6274) - CHANGED: Enable more clang-tidy checks. [Project-OSRM#6270](Project-OSRM#6270) - CHANGED: Configure clang-tidy job on CI. [Project-OSRM#6261](Project-OSRM#6261) - CHANGED: Use Github Actions for building container images [Project-OSRM#6138](Project-OSRM#6138) - CHANGED: Upgrade Boost dependency to 1.70 [Project-OSRM#6113](Project-OSRM#6113) - CHANGED: Upgrade Ubuntu CI builds to 20.04 [Project-OSRM#6119](Project-OSRM#6119) - CHANGED: Make building osrm-routed optional [Project-OSRM#6144](Project-OSRM#6144) - FIXED: Run all unit tests in CI [Project-OSRM#5248](Project-OSRM#5248) - FIXED: Fix installation of Mason CMake and 32 bit CI build [Project-OSRM#6170](Project-OSRM#6170) - FIXED: Fixed Node docs generation check in CI. [Project-OSRM#6058](Project-OSRM#6058) - CHANGED: Docker build, enabled arm64 build layer [Project-OSRM#6172](Project-OSRM#6172) - CHANGED: Docker build, enabled apt-get update/install caching in separate layer for build phase [Project-OSRM#6175](Project-OSRM#6175) - FIXED: Bump CI complete meta job to ubuntu-20.04 [Project-OSRM#6323](Project-OSRM#6323) - CHANGED: Node packages are now scoped by @Project-OSRM [Project-OSRM#6386](Project-OSRM#6386) - Routing: - CHANGED: Lazily generate optional route path data [Project-OSRM#6045](Project-OSRM#6045) - FIXED: Completed support for no_entry and no_exit turn restrictions. [Project-OSRM#5988](Project-OSRM#5988) - ADDED: Add support for non-round-trips with a single fixed endpoint. [Project-OSRM#6050](Project-OSRM#6050) - FIXED: Improvements to maneuver override processing [Project-OSRM#6125](Project-OSRM#6125) - ADDED: Support snapping to multiple ways at an input location. [Project-OSRM#5953](Project-OSRM#5953) - FIXED: Fix snapping target locations to ways used in turn restrictions. [Project-OSRM#6339](Project-OSRM#6339) - ADDED: Support OSM traffic signal directions. [Project-OSRM#6153](Project-OSRM#6153) - FIXED: Ensure u-turn exists in intersection view. [Project-OSRM#6376](Project-OSRM#6376) - FIXED: Gracefully handle no-turn intersections in guidance processing. [Project-OSRM#6382](Project-OSRM#6382) - Profile: - CHANGED: Bicycle surface speeds [Project-OSRM#6212](Project-OSRM#6212) - Tools: - CHANGED: Do not generate intermediate .osrm file in osrm-extract. [Project-OSRM#6354](Project-OSRM#6354)

SiarheiFedartsou added 18 commits August 28, 2022 11:01

Use apt-get to install Clang on CI

7e846c8

Use apt-get to install Clang on CI

8d87fd8

Use apt-get to install Clang on CI

a3a5e38

Use apt-get to install Clang on CI

d34e490

Use apt-get to install Clang on CI

8dafd57

Use apt-get to install Clang on CI

a028757

Use apt-get to install Clang on CI

c52073d

Use apt-get to install Clang on CI

f39b33a

Use apt-get to install Clang on CI

84c96bb

Use apt-get to install Clang on CI

469c1e1

Use apt-get to install Clang on CI

9a9b1f0

Use apt-get to install Clang on CI

7618b1d

Use apt-get to install Clang on CI

397052c

Use apt-get to install Clang on CI

c349518

Use apt-get to install Clang on CI

b0ecc57

Use apt-get to install Clang on CI

87821c4

Use apt-get to install Clang on CI

e768fb9

Use apt-get to install Clang on CI

f82796b

SiarheiFedartsou commented Aug 28, 2022

View reviewed changes

SiarheiFedartsou marked this pull request as ready for review August 28, 2022 09:53

SiarheiFedartsou commented Aug 28, 2022

View reviewed changes

Use apt-get to install Clang on CI

bc521ab

SiarheiFedartsou force-pushed the sf-clang-mason branch from d117a3f to bc521ab Compare August 29, 2022 21:11

SiarheiFedartsou added 5 commits August 29, 2022 23:16

Use apt-get to install Clang on CI

a54221a

Use apt-get to install Clang on CI

ddeb733

Use apt-get to install Clang on CI

31fbbed

Use apt-get to install Clang on CI

58a5592

Use apt-get to install Clang on CI

3f5b19b

SiarheiFedartsou added 2 commits August 29, 2022 23:38

Use apt-get to install Clang on CI

6bea064

Use apt-get to install Clang on CI

61eb847

SiarheiFedartsou requested a review from mjjbell August 29, 2022 21:48

mjjbell approved these changes Aug 29, 2022

View reviewed changes

Use apt-get to install Clang on CI

2790ed0

SiarheiFedartsou merged commit d8b358e into Project-OSRM:master Aug 30, 2022

mattwigway pushed a commit to mattwigway/osrm-backend that referenced this pull request Jul 20, 2023

Use apt-get to install Clang on CI (Project-OSRM#6345)

375e6d7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use apt-get to install Clang on CI #6345

Use apt-get to install Clang on CI #6345

SiarheiFedartsou commented Aug 28, 2022 •

edited

Loading

SiarheiFedartsou Aug 28, 2022

mjjbell Aug 28, 2022

SiarheiFedartsou Aug 28, 2022

SiarheiFedartsou Aug 29, 2022

mjjbell Aug 29, 2022

SiarheiFedartsou Aug 29, 2022

SiarheiFedartsou Aug 29, 2022

SiarheiFedartsou Aug 28, 2022

SiarheiFedartsou Aug 28, 2022

SiarheiFedartsou Aug 28, 2022

mjjbell Aug 28, 2022

mjjbell Aug 29, 2022

Use apt-get to install Clang on CI #6345

Use apt-get to install Clang on CI #6345

Conversation

SiarheiFedartsou commented Aug 28, 2022 • edited Loading

Issue

Tasklist

Requirements / Relations

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SiarheiFedartsou commented Aug 28, 2022 •

edited

Loading