Add Arabic localization #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reviewed the test fixtures and made some corrections at Transfix. |
|
Thanks, I updated the PR with your changes. |
danpaz
reviewed
Sep 24, 2018
| @@ -6,6 +6,7 @@ | |||
| "name": "Street Name" | |||
| }, | |||
| "instructions": { | |||
| "ar": "لقد وصلت إلى الوجهة ", | |||
There was a problem hiding this comment.
Is the trailing whitespace here expected?
There was a problem hiding this comment.
Here’s the format string:
{nth} resolves to the empty string, but it appears at the end of the format string, so it doesn’t get collapsed down:
osrm-text-instructions/index.js
Line 286 in b692dfb
The same issue affects Vietnamese. I guess technically OSRMTI could trim the final message if it causes problems for clients.
frederoni
approved these changes
Sep 26, 2018
kevinkreiser
added a commit
that referenced
this pull request
Mar 29, 2019
- Added a Hungarian localization and grammar. [#274](#274) - Added a Japanese localization. [#277](#277) - Added an Arabic localization. [#267](#267) - Added a Slovenian localization. [#264](#264) - Updated Russian arrive instructions. [#278](#278) - Updated French grammar with 'chaussée' status street name and better articles matching. [#268](https://github.com/Project-OSRM/osrm-text-instructions/pull/268)[#279](https://github.com/Project-OSRM/osrm-text-instructions/pull/279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a complete Arabic localization from Transifex, courtesy of @RazanQ.
@RazanQ, please review the test fixtures to ensure that your translations are joined into correct sentences. Feel free to make corrections at Transifex; this PR will be updated with your translations before merging. Thanks for your contributions!
Fixes #266.
/cc @danpaz