Add Japanese localization #277
Conversation
There was a problem hiding this comment.
Looks fine to me as long as @joshandrews gives the thumbs-up. Thanks for opening this PR, @yuryleb!
/cc @friedbunny
|
Unfortunately I could not check frontend in Japan (router.project-osrm.org always returned Route error for any requests inside Japan cities somehow), please look at Japanese instructions over US map: |
languages/translations/ja.json
Outdated
| "v5": { | ||
| "constants": { | ||
| "ordinalize": { | ||
| "1": "1 番", |
There was a problem hiding this comment.
I’m not sure about the project-specific requirements here, but in general there would be no space between a number and a counting word (like 番).
There was a problem hiding this comment.
I think so. @joshandrews, could you please fix this in Transifex?
|
Thanks for the feedback everyone. A couple updates:
|
|
We have updated the translations. @yuryleb can you pull in most recent from Transifex? |
| "v5": { | ||
| "constants": { | ||
| "ordinalize": { | ||
| "1": "1 つ目の", |
There was a problem hiding this comment.
Still whitespaces after digits, is it ok?
There was a problem hiding this comment.
Yes this is intended. This structure should work best based on the way sentences are formed.
There was a problem hiding this comment.
@yuryleb Everything looks good to me with the updated translations.
|
@yuryleb Let me know if there is anything I can do to help get this past the finish line. |
|
We did all we could, the PR could merged by maintainers only |
|
Thanks for all your help @joshandrews @yuryleb! |
- Added a Hungarian localization and grammar. [#274](#274) - Added a Japanese localization. [#277](#277) - Added an Arabic localization. [#267](#267) - Added a Slovenian localization. [#264](#264) - Updated Russian arrive instructions. [#278](#278) - Updated French grammar with 'chaussée' status street name and better articles matching. [#268](https://github.com/Project-OSRM/osrm-text-instructions/pull/268)[#279](https://github.com/Project-OSRM/osrm-text-instructions/pull/279)
Issue
Initial Japanese translation contributed by @joshandrews (#276).
Thanks a lot!
Tasklist