Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/check for api assets build output directory before copying for vercel adapter #1165

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 13, 2023

Related Issue

Observed in thescientist13/greenwood-lit-ssr#7 that we need to check for public/api/assets directory before trying to copy, otherwise an error will occur

[Error: ENOENT: no such file or directory, lstat '/Users/owenbuckley/Workspace/github/greenwood-demo-adapter-vercel-lit/public/api/assets/'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'lstat',
  path: '/Users/owenbuckley/Workspace/github/greenwood-demo-adapter-vercel-lit/public/api/assets/'
}

This is being done in the [Netlify adapter](https://github.com/ProjectEvergreen/greenwood/blob/release/0.29.0/packages/plugin-adapter-netlify/src/index.js#L168( so seems like it was just something I missed for the Vercel one.

Summary of Changes

  1. Check for public/api/assets directory before trying to copy bundles
  2. Fix a variable typo in a console.warn in rollup.config.js

@thescientist13 thescientist13 added bug Something isn't working Adapter labels Oct 13, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone Oct 13, 2023
@thescientist13 thescientist13 changed the title check for api assets build output directory before copying for vercel… check for api assets build output directory before copying for vercel adapter Oct 13, 2023
@thescientist13 thescientist13 changed the title check for api assets build output directory before copying for vercel adapter bug/check for api assets build output directory before copying for vercel adapter Oct 13, 2023
@thescientist13 thescientist13 force-pushed the bug/directory-check-for-api-assets-output-dir-vercel-adapter branch from 4bade4d to e2d44b7 Compare October 14, 2023 00:18
@thescientist13 thescientist13 merged commit 1f43653 into release/0.29.0 Oct 14, 2023
7 checks passed
@thescientist13 thescientist13 deleted the bug/directory-check-for-api-assets-output-dir-vercel-adapter branch October 14, 2023 00:34
@thescientist13 thescientist13 mentioned this pull request Oct 14, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant