Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove workaround for missing assets build output directory build error #7

Merged
merged 2 commits into from
Oct 14, 2023
Merged

remove workaround for missing assets build output directory build error #7

merged 2 commits into from
Oct 14, 2023

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Oct 13, 2023 •
edited
Loading

resolves #5

TODO

  1. need to guard against assuming there will be a public/api/assets directory for adapter plugins (vercel and netlify) - bug/check for api assets build output directory before copying for vercel adapter ProjectEvergreen/greenwood#1165
  2. fix variable name in rollup console logging - bug/check for api assets build output directory before copying for vercel adapter ProjectEvergreen/greenwood#1165
  3. apply patch fix and remove patch-package

@thescientist13 thescientist13 added bug Something isn't working needs upstream labels Oct 13, 2023
@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
greenwood-demo-adapter-vercel-lit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 1:29am

@thescientist13 thescientist13 mentioned this pull request Oct 13, 2023
Merged
@thescientist13 thescientist13 self-assigned this Oct 13, 2023
@thescientist13 thescientist13 added chore and removed bug Something isn't working labels Oct 14, 2023
@thescientist13 thescientist13 marked this pull request as ready for review October 14, 2023 01:31
@thescientist13 thescientist13 changed the title remove workaround for missing assets build output directory error remove workaround for missing assets build output directory build error Oct 14, 2023
@thescientist13 thescientist13 merged commit 97921cf into main Oct 14, 2023
1 check passed
@thescientist13 thescientist13 deleted the bug/issue-5-missing-assets-directory-build-output branch October 14, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build failing on missing output assets directory
1 participant
@thescientist13