Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop displaying 'added from url placeholder' #3448

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Jun 14, 2021

Fixes #3270

I've left the i18n strings in place, on the off-chance they are used downstream or in plugins 🤷

mjgiarlo
mjgiarlo previously approved these changes Jun 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3448 (9d7fe2d) into master (453f1a3) will not change coverage.
The diff coverage is n/a.

❗ Current head 9d7fe2d differs from pull request most recent head 2de7f22. Consider uploading reports for the commit 2de7f22 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3448   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         198      198           
  Lines        3409     3409           
=======================================
  Hits         3031     3031           
  Misses        378      378           
Impacted Files Coverage Δ
src/components/ManifestListItem.js 92.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453f1a3...2de7f22. Read the comment docs.

@mjgiarlo mjgiarlo merged commit 5d89ce6 into master Jun 25, 2021
@mjgiarlo mjgiarlo deleted the 3270-added-from-url branch June 25, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove “(Added from URL)” string from catalog items
3 participants