Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop displaying 'added from url placeholder' #3448

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Stop displaying 'added from url placeholder' #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/src/components/ManifestListItem.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ describe('ManifestListItem', () => {
expect(wrapper.find('.mirador-manifest-list-item-provider').children().text()).toEqual('ACME');
});

it('displays a placeholder provider if no information is given', () => {
it('displays nothing if no information is given', () => {
const wrapper = createWrapper();
expect(wrapper.find('.mirador-manifest-list-item-provider').children().text()).toEqual('addedFromUrl');
expect(wrapper.find('.mirador-manifest-list-item-provider').children().length).toEqual(0);
});

it('displays a collection label for collections', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/ManifestListItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export class ManifestListItem extends React.Component {
</ButtonBase>
</Grid>
<Grid item xs={8} sm={4}>
<Typography className={ns('manifest-list-item-provider')}>{provider || t('addedFromUrl')}</Typography>
<Typography className={ns('manifest-list-item-provider')}>{provider}</Typography>
<Typography>{t('numItems', { count: size, number: size })}</Typography>
</Grid>

Expand Down