Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the "no more validation missions" screen work on mobile? #2677

Closed
misaugstad opened this issue Sep 3, 2021 · 2 comments · Fixed by #3303
Closed

Does the "no more validation missions" screen work on mobile? #2677

misaugstad opened this issue Sep 3, 2021 · 2 comments · Fixed by #3303

Comments

@misaugstad
Copy link
Member

Brief description of problem/feature

We just brought up the Chicago server today. @jonfroehlich was doing validation on mobile, and after finishing a mission, the site seems to freeze/crash. It is likely because there were no more validation left to do, but there is a screen that's supposed to show up when that happens. We should investigate if that's working on mobile! This is what Jon's screen looked like after finishing the mission:
File

System info (OS, browser, city, and local/prod/test)

Prod on mobile, not sure which OS/browser.

@misaugstad
Copy link
Member Author

Okay I just tried on my phone because I know that there aren't enough labels for me to validate. The screen did show up. This is a different situation though, because I had no labels to validate; we need to test where you complete at least one validation mission and then run out of labels, which is what happened to @jonfroehlich.

The other obvious problem here is that the expected modal says that since there are no labels to validate, you should just start exploring! Buuut we can't do that on mobile. So this modal should be modified for mobile anyway. It could say that you can add more labels using the laptop/desktop computer.

IMG_8155

@misaugstad
Copy link
Member Author

@jonfroehlich I'm thinking that we let users know that they can add labels on desktop, or they can validate in another city, and link them to that other city as a replacement for the "Start Exploring" button. Does that sound like a decent idea to you? If so, should we just send everyone to Seattle? Or should we randomize it or something?

To recap @justyeethan there are two things to do here (and the first two are pending Jon's response):

  1. The text for this screen should be changed when on mobile to say "You can add more labels using a laptop/desktop computer, or you can validate labels in another city!"
  2. On mobile, the change the button from "Start Exploring" to "Validate in <city-name>"
  3. Make sure that users see this screen if there was at least one validation mission that a user could do, but they then ran out of available validations.

To test this issue, I'll send you a database that's mostly empty. You can add enough labels for a user to do a validation mission or two. That should help you test this case. You can keep opening up an incognito/private window to make a new anon account so that you can test repeatedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants