Gallery code refactor: replace the word 'modal'

[misaugstad]

Brief description of problem/feature

When Gallery was written, the expanded view that you get from clicking on a card was referred to as a "modal", but a modal is supposed to be something that prevents you from interacting with the other content on the page. This is clearly not the case here!

I'd like to rename Modal.js, and generally replace that word in the Gallery code. The best thing I've come up in the interim is "Expanded View", and that's how I've been referring to it in Github and in the code for a few months. How do we feel about changing Modal.js to ExpandedView.js or just Expanded.js? Other ideas for how you would refer to the more detailed view of the label when clicking on the cards?

[jonfroehlich]

Totally agree. And I like ExpandedView.js

…

On Thu, Apr 27, 2023 at 2:49 PM Michael Saugstad ***@***.***> wrote: Brief description of problem/feature When Gallery was written, the expanded view that you get from clicking on a card was referred to as a "modal", but a modal is supposed to be something that prevents you from interacting with the other content on the page. This is clearly not the case here! I'd like to rename Modal.js, and generally replace that word in the Gallery code. The best thing I've come up in the interim is "Expanded View", and that's how I've been referring to it in Github and in the code for a few months. How do we feel about changing Modal.js to ExpandedView.js or just Expanded.js? Other ideas for how you would refer to the more detailed view of the label when clicking on the cards? — Reply to this email directly, view it on GitHub <#3221>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAML55IJM2D2V5GCK4MFYILXDLSXDANCNFSM6AAAAAAXONXHPA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Jon E. Froehlich <https://jonfroehlich.github.io/> (he/him <https://www.mypronouns.org/he-him>) | @jonfroehlich <https://twitter.com/jonfroehlich> Associate Professor, Allen School of Computer Science & Engineering <https://www.cs.washington.edu/> Director, Makeability Lab <https://makeabilitylab.cs.washington.edu/> | Assoc. Director, CREATE <http://create.uw.edu/> | Faculty Chair, MHCI+D <https://mhcid.washington.edu/> Help make sidewalks more accessible: http://projectsidewalk.org

[misaugstad]

@LeeJoh22 here's your next task! One thing to keep in mind is our recommended line length limit of 120 characters, since "ExpandedView" is longer than "Modal"! Make sure to start by playing with Gallery for awhile, clicking on every button so that you know what they all do and can ensure that everything is still working as intended after the refactor. Though you don't need to use the "City" dropdown; it will send you from your local dev env to a test server for the city you click on! Just be careful of that.