3221 refactor gallery modal naming #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misaugstad
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Nothing seems to be broken, just a few more changes to make!
- The filename was changed from "Modal.js" to "ExpandedView.js", but the dir it's in is still called "modal".
- Still a reference to "modal" in a comment in "GalleryPanorama.js"
- Still a reference to "modal" in a comment in "ValidationMenu.js"
public/javascripts/Gallery/src/displays/ValidationInfoDisplay.js
Outdated
Show resolved
Hide resolved
|
I implemented the comments you left in new commit |
misaugstad
requested changes
Sep 30, 2024
| * @constructor | ||
| */ | ||
| function Keyboard(modal) { | ||
| function Keyboard(ExpandedView) { |
There was a problem hiding this comment.
Oh, didn't notice this last time: naming convention for parameters is camelCase, not PascalCase
misaugstad
approved these changes
Oct 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3221
Refactored Gallery code to replace 'Modal' with 'ExpandedView'.
Testing instructions
Things to check before submitting the PR