v6.8.4 #2132
Merged
v6.8.4 #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
misaugstad
commented
Jun 10, 2020
misaugstad
commented
- Adds a comment text field to the validation page Open-form textfield for validation interface #2100 (PR 2100 Add Validation Comment Text Field #2118)
- Now showing total validations in sidebar Should show total number of completed validations on sidebar #1776 (PR 1776 validate show total validations #2029)
- Changed the Spanish neighborhoods translation colonia -> barrio Change colonias to barrios outside of CDMX #2112 (PR 2112 colonias to barrios #2125)
- Fixes a bug where mission progress stuck at 0% on explore page Mission progress stuck at 0% #2120 (PR hotfix for #2120, mission progress bar should not be stuck at 0 now #2123)
- Adds a lucha libre mask version of the logo for Mexican cities Add lucha libre mask version of logo to CDMX server #2086 (PR #2086 Add Lucha Libre Mask #2121)
- Adds pano ID to popups on /labelmap and admin page Add pano id to GSV popup on admin page and /labelmap #2122 (PR 2122 Add Pano ID To GSV popop on admin page and labelmap #2127)
- Fixes a translation bug on the audit mission complete modal Audit Mission Complete Screen Mission Labels #2088 (PR 2112 colonias to barrios #2125)
- Fixes a progress bar issue when exploring the end of a street Pano registered as visited despite never being visited #1891 (PR 1891 Update Pano When Near Task End Validate #2109)
- Improves back-end loggin with a unique naming scheme Give application log unique naming scheme #2093 (PR Adds a unique naming scheme for logs when app restarts #2126)
- Adds logging for more links on landing page Log landing page clicks on other city and mapathon links #2067 (PR #2067 Log landing page clicks on city and mapathon #2090)
Changed the label from the amount of labels completed in the current mission to how labels completed in one stretch, by using svv.misisonsCompleted TODO: change svv.missionsCompleted to store the amount of missions the user has completed in all time
Queried the database for the total completed validations for each user, and got the data to be available in Mission.js
Changed the label in validate to show the total number of validations performed by the current user
Made the label count correct for the first time the validation page loads
Fixed a bug that would change the value of the labels completed during the mission end screen
Changed countCompletedValidationMissionsByUserID in MisstionTable.scala to count all of the validated labels instead of counting all of the validated missions.
Edited all of the files responsible for displaying the amount of validations performed by the user, to instead use the total number of labels validated instead of total number of validation missions completed.
…Webpage into 1776-validate-show-total-validations
The label is updated by taking the number being displayed to the user and incrementing the number. Added a helper function in StatusField to help with the incrementing.
….com/ProjectSidewalk/SidewalkWebpage into 1776-validate-show-total-validations
Since the total completed validations is stored in svv.validationsCompleted when loaded from the database, the labels now just displays the value of svv.validationsCompleted and increments the variable each time a validation is made.
Started storing the value of total completed validations in StatusField by passing it in as a parameter, and changed updating to requiring the increment and refresh methods be called in StatusField
Removed updateLabelCount and every use of the function. The new process for updating the labels is to send the value to statusField as a parameter and call refreshLabelCountsDisplay() or incrementLabelCounts()
… task end. If the user is within 25 meters of the end of the task, the next task is immediately generated and the remaining portion of the task segment is marked as complete.
Added a text area for label comments and submitting data to the validation_task_comment table.
Sends data to table whenever user clicks on textfield or submits data from textfield.
The application can now distringuish when user is using a keyboard shortcut to validate labels and when the user is typing information into the text field.
…Webpage into 1891-Pano-Registered-As-Visited-Early
Since the text area is not yet available on mobile, we should check if it exists before attaching an onpress function to it.
Style Fixes
…Webpage into 1776-validate-show-total-validations
2100 Add Validation Comment Text Field
…Webpage into 1891-Pano-Registered-As-Visited-Early
…-Visited-Early 1891 Update Pano When Near Task End Validate
…on-colonias-to-barrios 2112 colonias to barrios
…-naming-scheme Adds a unique naming scheme for logs when app restarts
…Webpage into 2122-Add-Pano-ID-GSV-Popup
2122 Add Pano ID To GSV popop on admin page and labelmap
…licks #2067 Log landing page clicks on city and mapathon
…re-mask #2086 Add Lucha Libre Mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.