Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename some simplied chinese to traditional chinese #3284

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

jimmywangtw
Copy link
Contributor

To enhance readability for Taiwanese individuals, certain Simplified Chinese characters are converted to their Traditional Chinese counterparts

  • [ x] I've written a descriptive PR title.

@jimmywangtw jimmywangtw marked this pull request as ready for review July 7, 2023 08:07
@misaugstad misaugstad self-requested a review July 7, 2023 22:02
@misaugstad
Copy link
Member

Thank you for the PR with the improved translations @jimmywangtw! There a bunch of extra formatting changes in there, so next week I'll go through and submit a new PR without the formatting changes if you haven't already!

@jimmywangtw
Copy link
Contributor Author

Some tabs are indented with two spaces, while others are indented with four spaces. It would be great if you could review the changes and make the final decision. :)

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tabs are indented with two spaces, while others are indented with four spaces

Thank you for bringing that to my attention! I just fixed this in #3291 and the PR looks good. Thank you so much for the updates!!

@misaugstad misaugstad merged commit 8bc0af8 into ProjectSidewalk:develop Jul 10, 2023
@misaugstad misaugstad mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants