Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redudant call and dom modal clean up #3542

Closed
wants to merge 1 commit into from

Conversation

JeremyFreiburger
Copy link
Collaborator

Resolves #3512

The problem was opening a modal on the label map reinitialized the panorama every time creating too many web gl elements. I also have to remove the code to remove the modal because I think it is interfering with bootstraps garbage collection/reusing modals.

Before/After screenshots (if applicable)
Testing instructions
  1. I tested pretty thoroughly, for each label type, validation type, and other data imported to make sure that it is the panorama that is creating too many webgl elements. When I only remove the reset call the problem still occurs.
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • [x ] I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • [ x] I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.
  • I've tested on mobile (only needed for validation page).

@misaugstad
Copy link
Member

Awesome!! Does removing the call to resetModal() cause any issues? Is all the data getting updated to the new label without the resetModal call?

And since this code is used in lots of places, I'm going to list all the places I can think of here. Can you check each place to see if it's an issue there on develop, and then make sure it's fixed in any places where it's an issue?

  1. LabelMap
  2. Admin page, "Map" tab
  3. Admin page, "Contributions" tab
  4. Admin user dashboard at /admin/user/<username>

@misaugstad
Copy link
Member

closing in favor of #3549

@misaugstad misaugstad closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LabelMap breaks if you look at too many labels
3 participants